-
Notifications
You must be signed in to change notification settings - Fork 61
docs: Improve README #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
whoisj
wants to merge
5
commits into
main
Choose a base branch
from
jwyman/improve-readme
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
docs: Improve README #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the README file to remove the "experimental" tag from the documentaion. The existance of the tag was an oversight as Torch 2.x has been supported for 18+ months at this point. Signed-off-by: J Wyman <[email protected]>
da24e73
to
fbf4be1
Compare
Update the README file to improve readability, clarity, and markdown formatting standards. Cleaned up and improvements were applied to the document: - Correctly indented content within bullet-point lists. - Used GitHub flavored markdown to enable NOTE, TIP, etc. callouts where appropriate. - Reflowed text to use the more standard new-line after every sentance style. - Replaced works this "this", "here", and "link" with more descriptive terms for link text. - Corrected the format of the pbtxt examples. - Updated the recommended pytorch container from NGC.
33b5537
to
987cf37
Compare
You may rebase to main now. |
yinggeh
reviewed
Oct 10, 2025
yinggeh
previously approved these changes
Oct 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on improving doc formatting and readability!
Use yaml instead of proto for code blocks to improve readability. Add example instance_group configuration.
yinggeh
reviewed
Oct 10, 2025
yinggeh
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the README file to improve readability, clarity, and markdown formatting standards.
Cleaned up and improvements were applied to the document: