Skip to content

Conversation

@yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Jul 10, 2025

Currently any new PR to core is blocked. https://github.com/triton-inference-server/core/pull/442/commits
The pipeline passed before because the following two tests were unintentionally skipped. See https://github.com/triton-inference-server/core/actions/runs/15383261092/job/43277349990.

=============================== warnings summary ===============================
python/test/test_api.py:443
  /core/python/test/test_api.py:443: PytestUnknownMarkWarning: Unknown pytest.mark.asyncio - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.asyncio

python/test/test_api.py:536
  /core/python/test/test_api.py:536: PytestUnknownMarkWarning: Unknown pytest.mark.asyncio - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.asyncio

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED python/test/test_api.py::TestInference::test_basic_async_inference - Failed: async def functions are not natively supported.
You need to install a suitable plugin for your async framework, for example:
  - anyio
  - pytest-asyncio
  - pytest-tornasync
  - pytest-trio
  - pytest-twisted
FAILED python/test/test_api.py::TestInference::test_async_inference_with_response_queue - Failed: async def functions are not natively supported.
You need to install a suitable plugin for your async framework, for example:
  - anyio
  - pytest-asyncio
  - pytest-tornasync
  - pytest-trio
  - pytest-twisted
== 2 failed, 79 passed, 6 skipped, 1 xfailed, 2 warnings in 101.66s (0:01:41) ==

@yinggeh yinggeh self-assigned this Jul 10, 2025
@yinggeh yinggeh added the PR: fix A bug fix label Jul 10, 2025
@yinggeh yinggeh changed the title fix: Update precheck pipeline to use the latest Triton version fix: Install pytest-asyncio Jul 10, 2025
@yinggeh yinggeh requested review from kthui and pranavm-nvidia July 10, 2025 20:03
@yinggeh yinggeh changed the title fix: Install pytest-asyncio fix: Fix core pull request workflow Jul 10, 2025
apt install -y --no-install-recommends clang-format-15 cmake libb64-dev rapidjson-dev libre2-dev
wget -O /tmp/boost.tar.gz https://archives.boost.io/release/1.80.0/source/boost_1_80_0.tar.gz && (cd /tmp && tar xzf boost.tar.gz) && mv /tmp/boost_1_80_0/boost /usr/include/boost && rm /tmp/boost.tar.gz
pip install build pytest
pip install build pytest pytest-asyncio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this was working before? Were the async tests added newly? In that case why didn't CI fail on the PR that introduced them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explained in the description. Maybe a recent version reports async def functions are not natively supported as error which used to be just warnings.

@yinggeh yinggeh merged commit ba7f004 into main Jul 10, 2025
2 checks passed
@yinggeh yinggeh deleted the yinggeh-fix-build-and-test branch July 28, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix A bug fix

Development

Successfully merging this pull request may close these issues.

3 participants