Skip to content

Rahul/finite fields #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GeorgeTsoukalas merged 2 commits into from
Jul 28, 2025
Merged

Rahul/finite fields #96

GeorgeTsoukalas merged 2 commits into from
Jul 28, 2025

Conversation

@rah4927
Copy link
Collaborator

@rah4927 rah4927 commented Jul 28, 2025 •
edited
Loading

  1. Added some repl commands to generate ground truth entities
  2. Added found names of some ground truth entities
  3. Combined nats and finite fields into one theory because both are needed
  4. Fixed some unit tests from earlier

@rah4927 rah4927 changed the base branch from main to rebuttal July 28, 2025 07:39
GeorgeTsoukalas
GeorgeTsoukalas approved these changes Jul 28, 2025
View reviewed changes
Copy link
Collaborator

@GeorgeTsoukalas GeorgeTsoukalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Approval

@GeorgeTsoukalas GeorgeTsoukalas merged commit 2ebac39 into rebuttal Jul 28, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeorgeTsoukalas GeorgeTsoukalas GeorgeTsoukalas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rah4927 @GeorgeTsoukalas