Skip to content

[DRAFT] removed symbolic expressions #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rah4927 merged 2 commits into from
Jul 9, 2025
Merged

[DRAFT] removed symbolic expressions #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7ede32
removed symbolic expressions
rah4927 May 27, 2025
5a01526
removed another symbolic expr
rah4927 Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions docs/update_demonstrations_docs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,6 @@ def generate_demonstrations_docs():
):
rst_content += f"**Arity**: {concept.example_structure.input_arity}\n\n"

# Add symbolic definition if available
if hasattr(concept, "symbolic_definition"):
rst_content += "This concept is formally defined in the FRAME expression language.\n\n"

# Show computational implementation availability
if hasattr(concept, "computational_implementation"):
rst_content += "The concept has a computational implementation that can execute on concrete values.\n\n"
Expand Down
2 changes: 0 additions & 2 deletions frame/environments/math_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,6 @@ def step(self, action: Union[int, ValidAction], is_simulation: bool = False) ->
theorem = Theorem(
name=new_entity.name,
description=new_entity.description,
symbolic_definition=new_entity._symbolic,
proof=cached_proof,
example_structure=new_entity.examples.example_structure,
lean4_translation=new_entity._lean4,
Expand Down Expand Up @@ -422,7 +421,6 @@ def step(self, action: Union[int, ValidAction], is_simulation: bool = False) ->
theorem = Theorem(
name=new_entity.name,
description=new_entity.description,
symbolic_definition=new_entity._symbolic,
proof=proof,
example_structure=new_entity.examples.example_structure,
lean4_translation=new_entity._lean4,
Expand Down
Loading