Test S3 file writing retries #27375
Closed
Test S3 file writing retries #27375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- register resources with closer as early as possible - use toxic name without spaces; it seems that names with spaces don't work correctly - drop redundant container configuration (network alias)
Network chaos (toxiproxy) setup is specific to assertions going to be performed. While we could test different setups and assertions with separate similar classes, this would be a lot of similar boilerplate code. This commit refactor the test class so that the test method configures network breakers.
This attempts to reproduce a problem that was observed on a production environment where S3 client side retries combined with `s3.exclusive-create=true` flag (default) where believed to cause failures during Iceberg maintenance procedures. This test did not reproduce that problem, but might be useful anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to reproduce a problem that was observed on a production
environment where S3 client side retries combined with
s3.exclusive-create=trueflag (default) where believed to causefailures during Iceberg maintenance procedures. This test did not
reproduce that problem, but might be useful anyway.
currently based on