Skip to content

Conversation

yangshangqing95
Copy link

@yangshangqing95 yangshangqing95 commented Sep 12, 2025

Description

This PR adds support for configuring the location of the Exchange Manager configuration file.
Users can now specify a custom path for the Exchange Manager config file, which allows for more flexible deployment and easier configuration management.


Additional context and related issues

Closes #26611

#26611


Release notes

(x) Release notes are required, with the following suggested text:

## General
* Add support for specifying the location of the Exchange Manager configuration file. ({issue}`26611`)

Copy link

cla-bot bot commented Sep 12, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@yangshangqing95 yangshangqing95 force-pushed the support-configurable-exchange branch from 9761f56 to a073be3 Compare September 12, 2025 19:40
Copy link

cla-bot bot commented Sep 12, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ebyhr ebyhr added the needs-docs This pull request requires changes to the documentation label Sep 13, 2025
@wendigo
Copy link
Contributor

wendigo commented Sep 13, 2025

Personally, I don't think that we want change like that. It doesn't solve any particular issue, at least none that is highlighted in that PR. How does it make deployment more flexible?

Copy link
Contributor

@wendigo wendigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@yangshangqing95 yangshangqing95 force-pushed the support-configurable-exchange branch from a073be3 to aa59d0d Compare September 15, 2025 15:50
Copy link

cla-bot bot commented Sep 15, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the docs label Sep 15, 2025
@yangshangqing95 yangshangqing95 force-pushed the support-configurable-exchange branch from aa59d0d to 985c156 Compare September 15, 2025 16:12
Copy link

cla-bot bot commented Sep 15, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@losipiuk
Copy link
Member

Personally, I don't think that we want change like that. It doesn't solve any particular issue, at least none that is highlighted in that PR. How does it make deployment more flexible?

I agree.

@yangshangqing95
Copy link
Author

Personally, I don't think that we want change like that. It doesn't solve any particular issue, at least none that is highlighted in that PR. How does it make deployment more flexible?

Hi @wendigo @losipiuk Thanks for reviewing the PR!

Let me clarify the motivation — the goal is to make deployments in containerized/Kubernetes environments more flexible.

issue link: #26611

Today ExchangeManagerRegistry always looks for
/etc/exchange-manager.properties, which creates a few practical issues:

In Kubernetes, configuration is usually mounted from Secrets or Vault Agent sidecars, and the target path is not always /etc/trino (sometimes it’s a read-only volume or gets replaced by the image build).

Helm charts and operators often template configs into arbitrary paths; to use exchange manager we currently have to copy/patch them into /etc/trino, which breaks immutability and complicates upgrades.

Other Trino subsystems (e.g. access-control.config-files, event-listener.config-files) already allow a custom location; but this component still relies on a hardcoded path.

By adding an optional property
exchange-manager.config-file=/path/to/exchange-manager.properties
we keep the existing default for backward compatibility, but remove the need to rebuild the image or override /etc/trino when running on K8s or integrating with Vault Agent.

So the change doesn’t affect default users, but gives operators more flexibility and aligns this component with the rest of the configuration system.

Would that address the concern about “no particular issue”? Happy to update the PR description.

@yangshangqing95
Copy link
Author

Hi @ebyhr Documentation has been added to reflect the new exchange-manager.config-file option, please help review, thank you!

@yangshangqing95 yangshangqing95 force-pushed the support-configurable-exchange branch from 985c156 to 9267001 Compare September 15, 2025 17:24
Copy link

cla-bot bot commented Sep 15, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ebyhr ebyhr removed the needs-docs This pull request requires changes to the documentation label Sep 15, 2025
@yangshangqing95 yangshangqing95 force-pushed the support-configurable-exchange branch from 9267001 to 4c6f571 Compare September 16, 2025 15:59
Copy link

cla-bot bot commented Sep 16, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Add support for specifying exchange manager config file location in config.
@yangshangqing95 yangshangqing95 force-pushed the support-configurable-exchange branch from 4c6f571 to b66e1db Compare September 16, 2025 21:15
Copy link

cla-bot bot commented Sep 16, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Feature Request: Make exchange-manager.properties file location configurable via ENV variable or config property
5 participants