Update download links in docs for GitHub releases #26473
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
commented
Aug 23, 2025
| filename = maven_filename(artifact, version, packaging, classifier) | ||
| return base + '/' + filename | ||
|
|
||
| def maven_download(group, artifact, version, packaging, classifier): |
There was a problem hiding this comment.
if you prefer we can also get rid of the old one..
wendigo
reviewed
Aug 23, 2025
| return '%s-%s%s.%s' % (artifact, version, classifier, packaging) | ||
|
|
||
| def github_release_download(group, artifact, version, packaging, classifier): | ||
| base = 'https://github.com/trinodb/trino/releases/download/' |
There was a problem hiding this comment.
I think the link should depend on version right? 477+ will be github
There was a problem hiding this comment.
yeah .. @martint is working on that - see https://github.com/trinodb/trino/releases/tag/477-test
There was a problem hiding this comment.
See next line.. it adds the version folder there
There was a problem hiding this comment.
And yeah .. we merge this before we cut 477
|
Did you see #26470? |
Nope .. you did not notify me or request review.. I will close this here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With 477 the binaries will be on GitHub... this updates all the links in the docs to the new planned location.
Should be merged before 477 is cut, so also before #26350
Additional context and related issues
Part of simpligility/contributions#23
Also see https://github.com/trinodb/trino/releases/tag/477-test
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.