Return only published main branch snapshots in history metadata table #26217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Jul 16, 2025
| for (Snapshot snapshot : icebergTable.snapshots()) { | ||
| long snapshotId = snapshot.snapshotId(); | ||
| Map<Long, Snapshot> snapshots = new HashMap<>(); | ||
| for (Snapshot snap : icebergTable.snapshots()) { |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
History table returns all snapshots right now. But it must only return published snapshots in main branch.
Modified the implementation to iterate over history entry instead of all snapshots.
Additional context and related issues
Iceberg/Spark reference implementation - https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/HistoryTable.java#L106
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(X ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: