Fix reading specifying format for date partition projection in Hive connector #25817
+147
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace legacy formatting with `DateTimeFormatter` for better compatibility with the `java.time` package, providing more precise and predictable behavior This refactor follows AWS Athena's date-type partition projection format (https://docs.aws.amazon.com/athena/latest/ug/partition-projection-supported-types.html) in the description. Additionally, this commit replaces the error-prone Supplier<Instant> with a direct Instant type for `leftBound` and `rightBound`.
Transform user-specified date partition projection format into Hive-compatible format for partition consistency.
chenjian2664
force-pushed
the
ref_date_projection
branch
from
af8efa8 to
6ef1fa6
Compare
pettyjamesm
reviewed
May 19, 2025
| @@ -138,7 +142,7 @@ public List<String> getProjectedValues(Optional<Domain> partitionValueFilter) | |||
|
|
|||
| Instant currentValue = leftBound; | |||
| while (!currentValue.isAfter(rightBound)) { | |||
| String currentValueFormatted = formatValue(currentValue); | |||
| String currentValueFormatted = formatValueToHiveCompatibleFormat(currentValue); | |||
There was a problem hiding this comment.
I don't think this is the intended behavior here- when we're enumerating the partition values we want to respect whatever format is specified for the timestamp and not limit it to the Hive compatible encoding. Otherwise #25642 isn't actually fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #25642
Make the partition value Hive format compatible during partition generation.
The pr is assume the underlay table path of partition is all Hive compatible format,
partitionName=${value}, even the customed partition projection is specified.Additional context and related issues
Alternative for #25657
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: