Fix missing file extension in Hive connector output files #25787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
hudi
Praveen2112
reviewed
May 14, 2025
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
wendigo
approved these changes
May 14, 2025
lib/trino-metastore/src/main/java/io/trino/metastore/StorageFormat.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveStorageFormat.java
Show resolved
Hide resolved
| @@ -675,7 +675,7 @@ public static int getBucketFromFileName(String fileName) | |||
| public static String getFileExtension(HiveCompressionCodec compression, StorageFormat format) | |||
| { | |||
| // text format files must have the correct extension when compressed | |||
| return compression.getHiveCompressionKind() | |||
| return format.getFileExtension() + compression.getHiveCompressionKind() | |||
plugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/TestStorage.java
Outdated
Show resolved
Hide resolved
chenjian2664
force-pushed
the
con16914_unload_extension
branch
5 times, most recently
from
c7888b2 to
4b61f65
Compare
chenjian2664
commented
May 14, 2025
| @@ -240,7 +240,12 @@ public static Optional<Boolean> directoryExists(TrinoFileSystem fileSystem, Loca | |||
|
|
|||
| public static boolean isFileCreatedByQuery(String fileName, String queryId) | |||
| { | |||
| return fileName.startsWith(queryId) || fileName.endsWith(queryId); | |||
| return fileName.startsWith(queryId) | |||
There was a problem hiding this comment.
we are using the logic to build fileName/Path, and expect the fileNames always startsWith or endsWith queryId, while the HiveWriteFactory#getFileExtension possible returns extension, it seems a bug previously
chenjian2664
force-pushed
the
con16914_unload_extension
branch
from
5dcb866 to
a217b4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: