Allow row column for equality delete #25729
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weijiii
force-pushed
the
fix-iceberg-eq-delete-constraint
branch
from
f6058b3 to
f515336
Compare
chenjian2664
reviewed
May 8, 2025
| public void testV2TableWithEqualityDeleteWhenColumnIsRow() | ||
| throws Exception | ||
| { | ||
| String tableName = "test_v2_equality_delete_column_is_row" + randomNameSuffix(); |
There was a problem hiding this comment.
Could you please add more test cases?
| @Override | ||
| public <T> void set(int i, T t) | ||
| { | ||
| throw new UnsupportedOperationException("Testing StructLike does not support setting values."); |
There was a problem hiding this comment.
Please update the exception message
| @@ -59,4 +82,84 @@ public String toString() | |||
| { | |||
| return "TrinoRow" + Arrays.toString(values); | |||
| } | |||
|
|
|||
| static Object getObjectValue(ConnectorSession session, Block block, int position, Type type) | |||
There was a problem hiding this comment.
Can we move this logic to IcebergPageSink, maybe an overload with getIcebergValue, or even maybe we could extract a util
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: