Skip to content

Show column comments on Hive views #25470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

codeDing18
Copy link
Contributor

@codeDing18 codeDing18 commented Apr 1, 2025

Description

Fix #23845

Release notes

## Hive
* Add support for showing column comments on Hive views. ({issue}`23845`)

Copy link

cla-bot bot commented Apr 1, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the hive Hive connector label Apr 1, 2025
@ebyhr
Copy link
Member

ebyhr commented Apr 1, 2025

@codeDing18 Did you submit CLA?

@codeDing18 codeDing18 force-pushed the hive-view-column-comment branch from 615be62 to 2b523f9 Compare April 1, 2025 07:00
Copy link

cla-bot bot commented Apr 1, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@codeDing18
Copy link
Contributor Author

@codeDing18 Did you submit CLA?

I sent the CLA email on March 12th

@codeDing18 codeDing18 force-pushed the hive-view-column-comment branch from 2b523f9 to 2db0546 Compare April 1, 2025 08:46
Copy link

cla-bot bot commented Apr 1, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@codeDing18 codeDing18 force-pushed the hive-view-column-comment branch from 2db0546 to 9ed6017 Compare April 1, 2025 12:14
Copy link

cla-bot bot commented Apr 1, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@codeDing18 codeDing18 force-pushed the hive-view-column-comment branch from 9ed6017 to 57c69aa Compare April 1, 2025 14:38
Copy link

cla-bot bot commented Apr 1, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ebyhr
Copy link
Member

ebyhr commented Apr 9, 2025

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Apr 9, 2025
Copy link

cla-bot bot commented Apr 9, 2025

The cla-bot has been summoned, and re-checked this pull request!

@ebyhr ebyhr force-pushed the hive-view-column-comment branch from 57c69aa to aa6a713 Compare April 9, 2025 01:07
@ebyhr ebyhr changed the title Improve HiveViewReader to show column comments Show column comments on Hive views Apr 9, 2025
@ebyhr ebyhr merged commit bbcf5a5 into trinodb:master Apr 9, 2025
58 checks passed
@github-actions github-actions bot added this to the 475 milestone Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed hive Hive connector
Development

Successfully merging this pull request may close these issues.

Show column comments in experimental mode on hive view
2 participants