Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow system tables to do system level access control #24726

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukasz-stec
Copy link
Member

@lukasz-stec lukasz-stec commented Jan 16, 2025

Description

This is an initial proposal to add an option to do access control checks during system table reads.
The goal here is to open this for discussion with some concrete option on a table.

Additional context and related issues

This is related to an effort to add an iceberg system table that lists only iceberg tables (#24469).
A system table like that has to filter the table list using the AccessControl#filterTables method but up until now, AccessControl was not available for system tables.

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jan 16, 2025
@lukasz-stec lukasz-stec force-pushed the ls/2501/03-system-table-access-control branch from 427247a to 0f82a5c Compare January 16, 2025 15:21
@mosabua mosabua requested a review from dain January 16, 2025 17:47
@lukasz-stec lukasz-stec force-pushed the ls/2501/03-system-table-access-control branch from 0f82a5c to 19fa449 Compare January 24, 2025 09:01
@lukasz-stec
Copy link
Member Author

I noticed that we already cast ConnectorSession to FullConnectorSession in multiple places. This makes this change pretty simple.

@lukasz-stec lukasz-stec marked this pull request as ready for review January 24, 2025 09:23
@lukasz-stec lukasz-stec force-pushed the ls/2501/03-system-table-access-control branch from 19fa449 to 3dfed42 Compare February 4, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant