Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test table comment in Faker #24598

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

sthandassery
Copy link
Contributor

@sthandassery sthandassery commented Dec 31, 2024

Description

Adding test coverage for setTableProperties. As part of the unit test getTableComment utility is now moved down from BaseConnectorTest to AbstractTestQueryFramework class, so that TestFakerQueries can reuse it.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

Copy link

cla-bot bot commented Dec 31, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added iceberg Iceberg connector delta-lake Delta Lake connector labels Dec 31, 2024
Copy link
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message and PR title are wrong

@ebyhr
Copy link
Member

ebyhr commented Dec 31, 2024

Fixes #23911

Please don't use "Fixes" comment. We should add more tests in #23911.

@sthandassery
Copy link
Contributor Author

The commit message and PR title are wrong

@nineinchnick Do you mean - moving the getTableComment utility needs to extracted out into its own commit?

@nineinchnick
Copy link
Member

This PR only moves getTableComment, so there's nothing to extract - change the commit message and PR title/description to explain why it's being moved.

Copy link

This pull request has gone a while without any activity. Tagging for triage help: @mosabua

@github-actions github-actions bot added the stale label Jan 23, 2025
@mosabua
Copy link
Member

mosabua commented Jan 27, 2025

Can you follow up on the review comments @sthandassery and then @nineinchnick and @raunaqmorarka can proceed towards merge.

@github-actions github-actions bot removed the stale label Jan 28, 2025
@ebyhr ebyhr force-pushed the test-faker-table-comments branch from 0243c65 to 73178bf Compare January 29, 2025 02:16
@cla-bot cla-bot bot added the cla-signed label Jan 29, 2025
@ebyhr ebyhr changed the title Add test for setTableProperties in Faker connector Test table comment in Faker Jan 29, 2025
@github-actions github-actions bot added the hive Hive connector label Jan 29, 2025
@ebyhr ebyhr force-pushed the test-faker-table-comments branch from 73178bf to 67fd24c Compare January 29, 2025 02:18
ebyhr and others added 2 commits January 29, 2025 11:27
@ebyhr ebyhr force-pushed the test-faker-table-comments branch from 67fd24c to 9fc7bfa Compare January 29, 2025 02:27
@ebyhr ebyhr merged commit 968ba48 into trinodb:master Jan 29, 2025
88 of 92 checks passed
@github-actions github-actions bot added this to the 470 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector hive Hive connector iceberg Iceberg connector
Development

Successfully merging this pull request may close these issues.

4 participants