-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test table comment in Faker #24598
Test table comment in Faker #24598
Conversation
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message and PR title are wrong
@nineinchnick Do you mean - moving the getTableComment utility needs to extracted out into its own commit? |
This PR only moves |
This pull request has gone a while without any activity. Tagging for triage help: @mosabua |
Can you follow up on the review comments @sthandassery and then @nineinchnick and @raunaqmorarka can proceed towards merge. |
0243c65
to
73178bf
Compare
73178bf
to
67fd24c
Compare
Co-Authored-By: Sandeep Thandassery <[email protected]>
Co-Authored-By: Sandeep Thandassery <[email protected]>
67fd24c
to
9fc7bfa
Compare
Description
Adding test coverage for setTableProperties. As part of the unit test
getTableComment
utility is now moved down from BaseConnectorTest to AbstractTestQueryFramework class, so that TestFakerQueries can reuse it.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.