Add DuckDB connector #23419
Merged
Add DuckDB connector #23419
+1,771
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/duckdb
branch
3 times, most recently
from
8ed5d45 to
914954c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ebyhr
force-pushed
the
ebi/duckdb
branch
3 times, most recently
from
68b7316 to
13afd4d
Compare
|
Thanks for contribution, sir. When can this PR merged and release? 🧐 |
ebyhr
force-pushed
the
ebi/duckdb
branch
3 times, most recently
from
41efaa5 to
00387f2
Compare
Some databases may map varchar(5) to different types.
|
(just rebased) |
Praveen2112
reviewed
Jan 29, 2025
plugin/trino-duckdb/src/main/java/io/trino/plugin/duckdb/DuckDblClientModule.java
Outdated
Show resolved
Hide resolved
plugin/trino-duckdb/src/main/java/io/trino/plugin/duckdb/DuckDbClient.java
Show resolved
Hide resolved
plugin/trino-duckdb/src/test/java/io/trino/plugin/duckdb/TestDuckDbConnectorTest.java
Show resolved
Hide resolved
plugin/trino-duckdb/src/test/java/io/trino/plugin/duckdb/TestDuckDbTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-duckdb/src/test/java/io/trino/plugin/duckdb/TestDuckDbTypeMapping.java
Show resolved
Hide resolved
plugin/trino-duckdb/src/test/java/io/trino/plugin/duckdb/TestDuckDbTypeMapping.java
Show resolved
Hide resolved
wendigo
reviewed
Jan 29, 2025
plugin/trino-duckdb/src/test/java/io/trino/plugin/duckdb/TestDuckDbConnectorTest.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Jan 29, 2025
plugin/trino-duckdb/src/test/java/io/trino/plugin/duckdb/TestDuckDbPlugin.java
Show resolved
Hide resolved
wendigo
reviewed
Jan 29, 2025
plugin/trino-duckdb/src/test/java/io/trino/plugin/duckdb/TestDuckDbConnectorTest.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Jan 29, 2025
plugin/trino-duckdb/src/test/java/io/trino/plugin/duckdb/TestingDuckDb.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Jan 29, 2025
plugin/trino-duckdb/src/test/java/io/trino/plugin/duckdb/TestingDuckDb.java
Outdated
Show resolved
Hide resolved
wendigo
approved these changes
Jan 29, 2025
|
Whoa! Amazing .. two new connectors in 470 at this stage .. |
Praveen2112
reviewed
Jan 30, 2025
plugin/trino-duckdb/src/main/java/io/trino/plugin/duckdb/DuckDbClient.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add DuckDB connector. This connector will be helpful for small local use case like #23344
Fixes #18031
Release notes