-
Notifications
You must be signed in to change notification settings - Fork 97
Add launcher and create tar for trino-gateway #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6df9e9a
to
8cd0ac7
Compare
8cd0ac7
to
b45b285
Compare
gateway-server/pom.xml
Outdated
</dependency> | ||
</dependencies> | ||
|
||
<!-- Needed for provisio to resolve transitive dependencies for server assembly --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed.. remove please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mosabua I have removed it
b45b285
to
10b4916
Compare
Can you please explain your motivation to add this. Currently the application is a single jar file and a simple Java command .. what benefits do we get from adding a tarball and launcher |
@mosabua Below listed things are my motivation which I liked having in trino-gateway similar to trino which was possible with this launcher addition
|
10b4916
to
d9b384e
Compare
We will need to add some documentation and upgrade the existing documentation .. I think to merge this we will want to no longer have documentation for the old jar use .. at least not documented.. and the docker image build has to be updated as well. Not sure if we should do this all in one PR or in separate steps .. thoughts @anilsomisetty @oneonestar @vishalya @willmostly @Chaho12 ? |
I don't mind changing at once as long as we have sufficient documentations as it is BREAKING change. |
d9b384e
to
b91d5fa
Compare
If you are able to work on the docker image, the docs updates, and also the quickstart and other assets. If we go for the tarball it should be a full switch over .. and ideally in one PR to ensure it all changes within one release. |
b91d5fa
to
d263818
Compare
d263818
to
ece7f37
Compare
Please change the module name and hence also the binary and more to trino-gateway-server .. that makes it consistent with trino itself. |
96e966a
to
e3a3726
Compare
e3a3726
to
e1df495
Compare
Description
This pr contains below changes to add launcher script and trino-gateway tar generation similar to trino:
How to manage the service with new changes:
Command: bin/launcher (run/start/stop/restart/kill/status) --config path_of_config.yml
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: