Respect range parameter for getObject in presign aware S3 clients #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laonel
force-pushed
the
patryk/presign-aware-client-get-range
branch
2 times, most recently
from
e684bde to
0bf703c
Compare
Randgalt
reviewed
May 14, 2025
trino-aws-proxy-spark3/src/main/java/io/trino/aws/proxy/spark3/PresignAwareAmazonS3.java
Show resolved
Hide resolved
Laonel
force-pushed
the
patryk/presign-aware-client-get-range
branch
from
0bf703c to
e45f2a5
Compare
If present, the range parameter from GetObjectRequest should be added to PresignedUrlDownloadRequest, so that the client gets the expected bytes.
Laonel
force-pushed
the
patryk/presign-aware-client-get-range
branch
from
e45f2a5 to
dffa947
Compare
Randgalt
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If present, the range parameter from GetObjectRequest should be added to PresignedUrlDownloadRequest, so that the client gets the expected bytes.