-
Notifications
You must be signed in to change notification settings - Fork 11
Add RemoteS3ConnectionProvider plugin implementations #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mosiac1
wants to merge
1
commit into
main
Choose a base branch
from
feat/refactor/plugin-impls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc398e6
to
801e9a1
Compare
00c4af6
to
abd2f9d
Compare
2dc5219
to
7c495ea
Compare
801e9a1
to
c4ec16b
Compare
c4ec16b
to
6547f3a
Compare
6547f3a
to
85a33f4
Compare
pranavr12
reviewed
May 16, 2025
...io/trino/aws/proxy/server/remote/provider/config/ConfigRemoteS3ConnectionProviderConfig.java
Outdated
Show resolved
Hide resolved
...io/trino/aws/proxy/server/remote/provider/config/ConfigRemoteS3ConnectionProviderModule.java
Outdated
Show resolved
Hide resolved
...main/java/io/trino/aws/proxy/server/remote/provider/http/HttpRemoteS3ConnectionProvider.java
Show resolved
Hide resolved
...main/java/io/trino/aws/proxy/server/remote/provider/http/HttpRemoteS3ConnectionProvider.java
Outdated
Show resolved
Hide resolved
...main/java/io/trino/aws/proxy/server/remote/provider/http/HttpRemoteS3ConnectionProvider.java
Show resolved
Hide resolved
...main/java/io/trino/aws/proxy/server/remote/provider/http/HttpRemoteS3ConnectionProvider.java
Show resolved
Hide resolved
...main/java/io/trino/aws/proxy/server/remote/provider/http/HttpRemoteS3ConnectionProvider.java
Show resolved
Hide resolved
...io/trino/aws/proxy/server/remote/provider/config/ConfigRemoteS3ConnectionProviderConfig.java
Outdated
Show resolved
Hide resolved
Added generic implementations for the RemoteS3ConnectionProvider interface: static, file and http. Added a README for the file and http ones as those are a bit more complex. Added more tests to dynamic RemoteS3Facade creation
85a33f4
to
a662e45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add generic implementations for the RemoteS3ConnectionProvider interface.
config, file and http
Added a README for the file and http ones as those are a bit more complex