Skip to content

fix: Unpin button in Sleep Image Picker now actually unpins #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HenriqueMorato wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Unpin button in Sleep Image Picker now actually unpins #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/activities/tools/SleepImagePickerActivity.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,8 +314,13 @@ void SleepImagePickerActivity::loop() {
}

const int items = totalItems();
buttonNavigator.onNext([this, items] { selectorIndex = ButtonNavigator::nextIndex(selectorIndex, items); requestUpdate(); });
buttonNavigator.onPrevious([this, items] { selectorIndex = ButtonNavigator::previousIndex(selectorIndex, items); requestUpdate(); });
// Bind Up/Down explicitly (not via onNext/onPrevious) so Left/Right stay free
// for the Pin/Unpin handler below — otherwise Left's button-down would move
// the cursor before wasReleased(Left) reads selectorIndex.
buttonNavigator.onPressAndContinuous({MappedInputManager::Button::Down},
[this, items] { selectorIndex = ButtonNavigator::nextIndex(selectorIndex, items); requestUpdate(); });
buttonNavigator.onPressAndContinuous({MappedInputManager::Button::Up},
[this, items] { selectorIndex = ButtonNavigator::previousIndex(selectorIndex, items); requestUpdate(); });

if (mappedInput.wasReleased(MappedInputManager::Button::Confirm)) {
if (selectorIndex == MODE_ITEM) {
Expand Down
Loading