Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STK: Don't access DualView's [h|d]_view directly #13788

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

masterleinad
Copy link
Contributor

@trilinos/stk

Motivation

kokkos/kokkos#7716 proposes to deprecate the ability to access DualView's h_view and d_view members directly since modifying the allocations can get perturbed the DualView's internal status. This pull request replaces all places in STK that use these members directly, in most places, verbatim with view_device resp. view_host.

Related Issues

Related to kokkos/kokkos#7716.

Signed-off-by: Daniel Arndt [email protected]

@masterleinad masterleinad requested a review from a team as a code owner February 5, 2025 20:07
Copy link
Contributor

@alanw0 alanw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@ldh4 can you bring this change to sierra?

@ldh4
Copy link
Contributor

ldh4 commented Feb 5, 2025

Looks good to me. @ldh4 can you bring this change to sierra?

Will do, but this change can't be applied in Sierra repo until Kokkos 4.6 is available in Sierra.
Nevermind, I misread about the deprecation detail.

@masterleinad
Copy link
Contributor Author

Will do, but this change can't be applied in Sierra repo until Kokkos 4.6 is available in Sierra.

The changes here don't require any recent Kokkos version, though.

@ldh4
Copy link
Contributor

ldh4 commented Feb 5, 2025

Will do, but this change can't be applied in Sierra repo until Kokkos 4.6 is available in Sierra.

The changes here don't require any recent Kokkos version, though.

Yep, I realized it right after making that comment.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants