Tempus: fix type limits #13716

ccober6 · 2025-01-09T01:12:44Z

Fix for bug found in #13692.

@trilinos/tempus

Related Issues

Related to Piro: tempus/transient solver mods. #13692

bartgol

I don't really know the data structure here, but the fix related to signed-ness of numEvents seems sound.

bartgol · 2025-01-09T01:23:53Z

The list of files changed seems correct, but the long list of commits is puzzling.

trilinos-autotester · 2025-01-09T01:25:12Z

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

trilinos-autotester · 2025-01-09T01:25:15Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

trilinos-autotester · 2025-01-09T02:05:32Z

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

cgcgcg

Something went wrong in a merge here..

trilinos-autotester · 2025-01-09T02:10:03Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 982
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`bfa3141`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`cc1fe7a`

Build Information

Test Name: PR_gcc

Build Num: 1032
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`bfa3141`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`cc1fe7a`

Build Information

Test Name: PR_gcc-openmpi_debug

Build Num: 1033
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`bfa3141`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`cc1fe7a`

Build Information

Test Name: PR_clang

Build Num: 1031
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`bfa3141`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`cc1fe7a`

Build Information

Test Name: PR_cuda

Build Num: 1030
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8-gpu
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`bfa3141`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`cc1fe7a`

Build Information

Test Name: PR_intel

Build Num: 951
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`bfa3141`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`cc1fe7a`

Build Information

Test Name: PR_cuda-uvm

Build Num: 1030
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`bfa3141`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`cc1fe7a`

Using Repos:

Repo: TRILINOS (ccober6/Trilinos)

Pull Request Author: ccober6

trilinos-autotester · 2025-01-09T02:43:19Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 982
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`bfa3141`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`cc1fe7a`

Build Information

Test Name: PR_gcc

Build Num: 1032
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`bfa3141`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`cc1fe7a`

Build Information

Test Name: PR_gcc-openmpi_debug

Build Num: 1033
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`bfa3141`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`cc1fe7a`

Build Information

Test Name: PR_clang

Build Num: 1031
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`bfa3141`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`cc1fe7a`

Build Information

Test Name: PR_cuda

Build Num: 1030
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8-gpu
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`bfa3141`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`cc1fe7a`

Build Information

Test Name: PR_intel

Build Num: 951
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`bfa3141`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`cc1fe7a`

Build Information

Test Name: PR_cuda-uvm

Build Num: 1030
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`bfa3141`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`cc1fe7a`

CDash Test Results for PR# 13716.

trilinos-autotester · 2025-01-09T02:43:39Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES!

trilinos-autotester · 2025-01-09T02:43:45Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sebrowne · 2025-01-09T14:07:53Z

FWIW it does appear that this warning caught a legitimate bug....

sebrowne · 2025-01-09T14:10:08Z

Something went wrong in a merge here..

@ccober6 I believe you'll want to rebase your change (59b84b4) onto the trilinos:develop branch (that's one way to do it at least).

ccober6 · 2025-01-09T14:50:13Z

I did a git pull yesterday afternoon before starting this PR, so unless something was added late yesterday I do not think a rebase will help. I will try it anyway to see.

ccober6 · 2025-01-09T14:56:34Z

So it appears everything is up to date, and the rebase didn't do anything.

s1089372: ~/myOffice/ccober6_Forks/Trilinos_Second/packages/tempus/unit_test :19
[543] (Tempus-Fix-type-limits)-> git fetch --all
Fetching origin
Fetching upstream
From github.com:trilinos/Trilinos
 * [new branch]              tpetra/copy-and-permute-3 -> upstream/tpetra/copy-and-permute-3
 
s1089372: ~/myOffice/ccober6_Forks/Trilinos_Second/packages/tempus/unit_test 9
[544] (Tempus-Fix-type-limits)-> git co master
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
 
s1089372: ~/myOffice/ccober6_Forks/Trilinos_Second/packages/tempus/unit_test 6
[545] (master)-> git merge upstream/master
Already up to date.
 
s1089372: ~/myOffice/ccober6_Forks/Trilinos_Second/packages/tempus/unit_test 9
[546] (master)-> git push origin master
Everything up-to-date
 
s1089372: ~/myOffice/ccober6_Forks/Trilinos_Second/packages/tempus/unit_test 4
[547] (master)-> git co develop 
Switched to branch 'develop'
Your branch is up to date with 'origin/develop'.
 
s1089372: ~/myOffice/ccober6_Forks/Trilinos_Second/packages/tempus/unit_test 7
[548] (develop)-> git merge upstream/develop 
Already up to date.
 
s1089372: ~/myOffice/ccober6_Forks/Trilinos_Second/packages/tempus/unit_test 9
[549] (develop)-> git push origin develop 
Everything up-to-date
 
s1089372: ~/myOffice/ccober6_Forks/Trilinos_Second/packages/tempus/unit_test 4
[550] (develop)-> git co Tempus-Fix-type-limits 
Switched to branch 'Tempus-Fix-type-limits'
Your branch is up to date with 'origin/Tempus-Fix-type-limits'.
 
s1089372: ~/myOffice/ccober6_Forks/Trilinos_Second/packages/tempus/unit_test 7
[551] (Tempus-Fix-type-limits)-> git rebase develop 
Current branch Tempus-Fix-type-limits is up to date.

Fix for bug found in trilinos#13692. Signed-off-by: Curtis C. Ober <[email protected]>

Signed-off-by: Curtis C. Ober <[email protected]>

trilinos-autotester · 2025-01-09T16:45:03Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

trilinos-autotester · 2025-01-09T16:50:16Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 986
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`82be494`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`baac3f6`

Build Information

Test Name: PR_gcc

Build Num: 1036
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`82be494`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`baac3f6`

Build Information

Test Name: PR_gcc-openmpi_debug

Build Num: 1037
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`82be494`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`baac3f6`

Build Information

Test Name: PR_clang

Build Num: 1035
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`82be494`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`baac3f6`

Build Information

Test Name: PR_cuda

Build Num: 1034
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8-gpu
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`82be494`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`baac3f6`

Build Information

Test Name: PR_intel

Build Num: 955
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`82be494`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`baac3f6`

Build Information

Test Name: PR_cuda-uvm

Build Num: 1034
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`82be494`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`baac3f6`

Using Repos:

Repo: TRILINOS (ccober6/Trilinos)

Pull Request Author: ccober6

trilinos-autotester · 2025-01-09T17:22:17Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 986
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`82be494`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`baac3f6`

Build Information

Test Name: PR_gcc

Build Num: 1036
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`82be494`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`baac3f6`

Build Information

Test Name: PR_gcc-openmpi_debug

Build Num: 1037
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`82be494`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`baac3f6`

Build Information

Test Name: PR_clang

Build Num: 1035
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`82be494`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`baac3f6`

Build Information

Test Name: PR_cuda

Build Num: 1034
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8-gpu
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`82be494`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`baac3f6`

Build Information

Test Name: PR_intel

Build Num: 955
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`82be494`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`baac3f6`

Build Information

Test Name: PR_cuda-uvm

Build Num: 1034
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;pkg: Tempus
PULLREQUESTNUM	13716
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ccober6/Trilinos
TRILINOS_SOURCE_SHA	`82be494`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`baac3f6`

CDash Test Results for PR# 13716.

trilinos-autotester · 2025-01-09T17:22:39Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartgol rppawlo cgcgcg ]!

trilinos-autotester · 2025-01-09T17:22:47Z

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

sebrowne · 2025-01-09T17:57:41Z

@ccober6 this is ready to merge now. AUTOMERGE was previously removed because of the git history, but everything is passing now and clean.

ccober6 added type: bug The primary issue is a bug in Trilinos code or tests pkg: Tempus labels Jan 9, 2025

ccober6 requested review from rppawlo and bartgol January 9, 2025 01:12

ccober6 self-assigned this Jan 9, 2025

ccober6 requested a review from a team as a code owner January 9, 2025 01:12

ccober6 added AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration labels Jan 9, 2025

bartgol approved these changes Jan 9, 2025

View reviewed changes

cgcgcg requested changes Jan 9, 2025

View reviewed changes

cgcgcg removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Jan 9, 2025

trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Jan 9, 2025

sebrowne mentioned this pull request Jan 9, 2025

Piro: tempus/transient solver mods. #13692

Merged

ccober6 added 2 commits January 9, 2025 08:14

Tempus: Fix type-limits

a99e9d0

Fix for bug found in trilinos#13692. Signed-off-by: Curtis C. Ober <[email protected]>

Clang-format change.

82be494

Signed-off-by: Curtis C. Ober <[email protected]>

ccober6 force-pushed the Tempus-Fix-type-limits branch from bfa3141 to 82be494 Compare January 9, 2025 15:17

bartgol approved these changes Jan 9, 2025

View reviewed changes

rppawlo approved these changes Jan 9, 2025

View reviewed changes

cgcgcg approved these changes Jan 9, 2025

View reviewed changes

ccober6 merged commit 4afdea6 into trilinos:develop Jan 9, 2025
15 of 17 checks passed

ccober6 deleted the Tempus-Fix-type-limits branch January 9, 2025 18:05

Tempus: fix type limits #13716

Tempus: fix type limits #13716

Conversation

ccober6 commented Jan 9, 2025

Related Issues

bartgol left a comment

Choose a reason for hiding this comment

bartgol commented Jan 9, 2025

trilinos-autotester commented Jan 9, 2025

trilinos-autotester commented Jan 9, 2025

trilinos-autotester commented Jan 9, 2025

cgcgcg left a comment

Choose a reason for hiding this comment

trilinos-autotester commented Jan 9, 2025

Build Information

Test Name: PR_gcc-openmpi-openmp

Jenkins Parameters

Build Information

Test Name: PR_gcc

Jenkins Parameters

Build Information

Test Name: PR_gcc-openmpi_debug

Jenkins Parameters

Build Information

Test Name: PR_clang

Jenkins Parameters

Build Information

Test Name: PR_cuda

Jenkins Parameters

Build Information

Test Name: PR_intel

Jenkins Parameters

Build Information

Test Name: PR_cuda-uvm

Jenkins Parameters

Using Repos:

trilinos-autotester commented Jan 9, 2025

Build Information

Test Name: PR_gcc-openmpi-openmp

Jenkins Parameters

Build Information

Test Name: PR_gcc

Jenkins Parameters

Build Information

Test Name: PR_gcc-openmpi_debug

Jenkins Parameters

Build Information

Test Name: PR_clang

Jenkins Parameters

Build Information

Test Name: PR_cuda

Jenkins Parameters

Build Information

Test Name: PR_intel

Jenkins Parameters

Build Information

Test Name: PR_cuda-uvm

Jenkins Parameters

trilinos-autotester commented Jan 9, 2025

trilinos-autotester commented Jan 9, 2025

sebrowne commented Jan 9, 2025

sebrowne commented Jan 9, 2025

ccober6 commented Jan 9, 2025

ccober6 commented Jan 9, 2025

trilinos-autotester commented Jan 9, 2025

trilinos-autotester commented Jan 9, 2025

Build Information

Test Name: PR_gcc-openmpi-openmp

Jenkins Parameters

Build Information

Test Name: PR_gcc

Jenkins Parameters

Build Information

Test Name: PR_gcc-openmpi_debug

Jenkins Parameters

Build Information

Test Name: PR_clang

Jenkins Parameters

Build Information

Test Name: PR_cuda