-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kokkos + KokkosKernels Promotion To 4.5.1 #13679
Kokkos + KokkosKernels Promotion To 4.5.1 #13679
Conversation
cac82fa
to
ba75ae9
Compare
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: ndellingwood |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
CDash failure summary: PR_cuda Multiple compilation failures in intrepid2 due to nvcc ice...
https://trilinos-cdash.sandia.gov/viewBuildError.php?buildid=2038117 All other jobs had lots of intrepid2 unit test failures, possibly related to kokkos/kokkos#7606 ? PR_clang
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: ndellingwood |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
Retested with changes corresponding to kokkos/kokkos#7625 |
…f607cbf6f89e47 From repository at [email protected]:kokkos/kokkos-kernels.git At commit: commit 42593705e42e661fe68151415df607cbf6f89e47 Author: Nathan Ellingwood <[email protected]> Date: Tue Dec 17 11:39:48 2024 -0700 update master_history.txt Signed-off-by: Nathan Ellingwood <[email protected]>
326f7ea
to
c514f03
Compare
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
…fb1861 From repository at [email protected]:kokkos/kokkos.git At commit: commit ff977240c493f8b5a170cb81c7dc111cd2fb1861 Author: Nathan Ellingwood <[email protected]> Date: Thu Dec 19 11:22:34 2024 -0700 update master_history.txt Signed-off-by: Nathan Ellingwood <[email protected]>
Signed-off-by: Nathan Ellingwood <[email protected]>
c514f03
to
d78b31d
Compare
Looks like the intel-2021.3 build will have test failures in intrepid2 Apparently small diffs from the tolerance? Why did they occur with this rerun? Sample case and output snip: Intrepid2_unit-test_Discretization_Basis_HCURL_TET_In_FEM_test_02_Serial_DOUBLE_DOUBLE_MPI_1
Full list: https://trilinos-cdash.sandia.gov/viewTest.php?onlyfailed&buildid=2043195 The failures did not occur in the prior run, with similar set of changes (only difference is an added abort check on rank that is not relevant to the failures - no aborts were triggered): Prior intel-2021.3 run: https://trilinos-cdash.sandia.gov/viewTest.php?onlypassed&buildid=2041732 |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
I really don't know. I had the same issues with similar tests on the intel build and I increased the tolerance. However, it might be better to disable those tests for now. I plan to work on that capability and fix a few issues that Christian identified when he looked at the code. Sorry for the issues they are causing. |
Thanks @mperego , I wasn't sure how concerned to be about the diff and tol trigger of the failures. The failures didn't occur with the other host builds (some with Serial backend enabled) and didn't occur in the previous intel-2021.3 run (which had the same low-rank drv operators()). |
Ah, I glanced at the Intrepid2_unit-test_Discretization_Basis_HCURL_TET_In_FEM_test_02_Serial_DOUBLE_DOUBLE_MPI_1 , there is random number generation used to initially fill the Edit: looking at the code, it looks like the seed was pinned, so input data should be consistent from run to run... |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: ndellingwood |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
Retest had the same test failures in the
Intrepid2 Intrepid2_unit-test_Discretization_Basis_HCURL_TET_In_FEM_test_02_Serial_DOUBLE_DOUBLE_MPI_1 @mperego I will try to disable as you suggested for later reevaluation |
The following tests have diff vs tol issues in the intel-2021.3 job Intrepid2_unit-test_Discretization_Basis_HCURL_TET_In_FEM_test_02_Serial_DOUBLE_DOUBLE_MPI_1 Intrepid2_unit-test_Discretization_Basis_HCURL_TRI_In_FEM_test_02_Serial_DOUBLE_DOUBLE_MPI_1 Intrepid2_unit-test_Discretization_Basis_HDIV_TET_In_FEM_test_02_Serial_DOUBLE_DOUBLE_MPI_1 Intrepid2_unit-test_Discretization_Basis_HDIV_TRI_In_FEM_test_02_Serial_DOUBLE_DOUBLE_MPI_1 Intrepid2_unit-test_Discretization_Basis_HGRAD_TET_Cn_FEM_test_02_Serial_DOUBLE_DOUBLE_MPI_1 Intrepid2_unit-test_Discretization_Basis_HGRAD_TRI_Cn_FEM_test_02_Serial_DOUBLE_DOUBLE_MPI_1 Intrepid2_unit-test_Discretization_Basis_HVOL_TET_Cn_FEM_test_02_Serial_DOUBLE_DOUBLE_MPI_1 Signed-off-by: Nathan Ellingwood <[email protected]>
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: ndellingwood |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test disables look fine
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ sebrowne crtrott ]! |
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
Merge on Pull Request# 13679: IS A SUCCESS - Pull Request successfully merged |
@trilinos/kokkos @trilinos/kokkos-kernels
Motivation
Snapshot Kokkos Ecosystem patch release 4.5.1 to Trilinos
put-issue-number-here
Testing
Various CI and nightly testing