Working baseline #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the extra "Wpf debug" and "Wpf release" configurations, as well as fixing the NtfsReader being set to Release in the default Debug profile
Target .NET Framework 4.8
Remove WinForms and Aero references Add Microsoft.Extensions.DependencyInjection package reference Add Ookii.Dialogs package reference
These types now wrap the WCT RelayCommand types by composition, rather than inheriting from them
Use the Microsoft.Extensions.DependencyInjection IOC implementation
Make ScanningService disposable
Use wildcards to include resources
…Stat.Net into working-baseline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the .NET 5.0 and WCT MVVM upgrade.
This PR adds a few additional changes to get the project building and running for basic functionality. There are still inconsistencies (like the behavior of
Thread.Abortin cancellations, seen in scanning and rendering) that differ from .NET Framework, but it's a working baseline.