feat(app): add Korean (ko) translation for the dashboard (closes #117) - #412
Open
dchaudhari7177 wants to merge 1 commit into
Open
feat(app): add Korean (ko) translation for the dashboard (closes #117)#412dchaudhari7177 wants to merge 1 commit into
dchaudhari7177 wants to merge 1 commit into
Conversation
Adds a complete ko catalog, the "ko" member of the Language union, ko to the
readSavedLanguage allowlist so a saved preference survives a reload, and a KO
option in the language switcher.
All 103 catalog keys are translated - verified programmatically against the en
catalog: no missing keys, no extra keys, and every {placeholder} token
({id}, {amount}, {token}, {count}, {total}, {pct}, {bps}, {address},
{controller}) matches its English counterpart exactly. That matters because t()
falls back to the raw KEY rather than to English when a key is absent, so a
partial catalog would render identifiers in the UI.
Korean has no plural inflection for these strings, so counts read naturally
with the interpolated number ("수취인 {count}명").
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117.
Adds a complete ko catalog, the
"ko"member of theLanguageunion,koin thereadSavedLanguageallowlist (so a saved preference survives a reload), and aKOoption in the language switcher.Completeness, checked rather than eyeballed
All 103 catalog keys are translated. Verified programmatically against the
encatalog:{placeholder}parity: no mismatches — every{id},{amount},{token},{count},{total},{pct},{bps},{address},{controller}matches its English counterpartThat last check matters more than it looks:
t()falls back to the raw key, not to English, when a key is missing —— so a partial catalog renders identifiers like
sharesTotalWarnstraight into the UI rather than degrading to English. A dropped placeholder would likewise silently lose the interpolated value.Translation notes
수취인 {count}명).Freighter,GitHub,friendbot,XLM,CSV,bps) are left untranslated.Verification
npx vitest run src/lib/i18n.test.tsx— 12 passednpm run build— 10 TypeScript errors, identical on pristinemain(git stash): all inStreamsCard.tsx/lib/tributary.tsagainsttributary-sdk, because the SDK workspace isn't built in this checkout. This change adds zero new errors.app/package-lock.jsonwas touched by my localnpm install; deliberately not committed.🤖 Generated with Claude Code