chore(suite): interface cleanup for TroubleshootingTips #17972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lemonexe
added
the
no-project
|
🔍🌐 Suite Web test results: View in Currents |
|
🔍🖥️ Suite Desktop test results: View in Currents |
Lemonexe
commented
Mar 28, 2025
| @@ -81,15 +81,15 @@ export const DeviceConnect = ({ setIsBluetoothConnectOpen }: DeviceConnectProps) | |||
|
|
|||
| return ( | |||
| <TroubleshootingTipsWithSections | |||
| label={<Translation id="TR_TREZOR_SAFE_7" />} | |||
| label={<Translation id="TR_CONNECTION_TYPE" />} | |||
| ctaLabel={<Translation id="TR_TREZOR_SAFE_7" />} | |||
There was a problem hiding this comment.
before → after:
sectionLabel→labellabel→ctaLabel
label is now the same thing for TroubleshootingTipsWithSections and for TroubleshootingTips, which was the most confusing thing for me personally..
Visually it is the most prominent label, as it headlines the table, so it makes sense that the name reflects that this is the label.
ctaLabel now actually behaves analogically to toggleText – it is just custom override, and if not supplied, a default will be used (label for cta, constant for toggle).
Here is currently the only usage of the ctaLabel override...
| const [selectedSection, setSelectedSection] = useState<K>(defaultSection); | ||
| const [isOpened, setIsOpened] = useState(initiallyIsOpen === true); | ||
| const firstSectionKey = Object.keys(items)[0] as K; | ||
| const [selectedSection, setSelectedSection] = useState<K>(defaultSection ?? firstSectionKey); |
peter-sanderson
approved these changes
Mar 31, 2025
Lemonexe
force-pushed
the
bluetooth-ready-wellcome-screen-CR-suggestion
branch
from
018d365 to
e2a5b9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ex post CR suggestions for #17925
Mainly refactor props, IMO more intuitive now and without too many diffs.
And small nits
Screenshots:
Proof that I did not mess up the order of the props:
BT on
BT off
What we've got here is failure to communicate
@coderabbitai ignore