Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SafeAreaProvider to BasicProvider for component tests #16607

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Add SafeAreaProvider to BasicProvider for component tests #16607

merged 1 commit into from
Jan 27, 2025

Conversation

jbazant
Copy link
Contributor

@jbazant jbazant commented Jan 27, 2025

Description

Added SafeAreaProvider to BasicProvider and mocked it in tests to simplify testing of some of our components (e.g. BottomSheet).

See react-native-safe-area-context testing docs for more info.

Related Issue

Resolve

Screenshots:

@jbazant jbazant added the mobile Suite Lite issues and PRs label Jan 27, 2025
@jbazant jbazant requested a review from a team as a code owner January 27, 2025 07:54
@jbazant jbazant requested a review from vytick January 27, 2025 07:55
vytick
vytick approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@vytick vytick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@vytick vytick added the no-project This label is used to specify that PR doesn't need to be added to a project label Jan 27, 2025
@vytick vytick merged commit dc369c6 into develop Jan 27, 2025
85 of 87 checks passed
@vytick vytick deleted the testing-safe-area branch January 27, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vytick vytick vytick approved these changes

Assignees
No one assigned
Labels
mobile Suite Lite issues and PRs no-project This label is used to specify that PR doesn't need to be added to a project
Projects
Suite Mobile
Status: 🎯 To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbazant @vytick