Feat/suite desktop core/convert unaquired device #16603
Conversation
rename refactor locator @deviceStatus and few cy tests split test to viewOnly enabled and false
|
🚀 Expo preview is ready!
|
Vere-Grey
force-pushed
the
feat/suite-desktop-core/convert-unaquired-device
branch
from
81ca301 to
4df18e2
Compare
fixes locators, leaves the original one in place until we get rid of cy
Vere-Grey
force-pushed
the
feat/suite-desktop-core/convert-unaquired-device
branch
from
4df18e2 to
d243c6a
Compare
| @@ -6,7 +6,7 @@ import { step } from '../common'; | |||
|
|
|||
| export class DevicePromptActions { | |||
| readonly confirmOnDevicePrompt: Locator; | |||
| private readonly connectDevicePrompt: Locator; | |||
| readonly connectDevicePrompt: Locator; | |||
There was a problem hiding this comment.
I want to expect the text in the locator on test level
| await test.step('Steal Bridge session', async () => { | ||
| const bridge = new BridgeTransport({ messages, id: 'foo-bar' }); | ||
| await bridge.init(); | ||
| const enumerateRes = await bridge.enumerate(); | ||
| if (!enumerateRes.success) return null; | ||
| await bridge.acquire({ | ||
| input: { path: enumerateRes.payload[0].path, previous: null }, | ||
| }); | ||
| }); |
There was a problem hiding this comment.
copy pasta from cypress suite
better logging of test steps
Vere-Grey
force-pushed
the
feat/suite-desktop-core/convert-unaquired-device
branch
from
77f5e6f to
a7b9e6d
Compare
There was a problem hiding this comment.
Once we convert all cypress test using these locators, we will simplify that to one statically named locator.
There was a problem hiding this comment.
Once we convert all cypress test using these locators, we will simplify that to one statically named locator. It is not good practice to build your expects around internal state and values of the UI. That way the internal state can be correct but the information shown to user can be still incorrect and test falsely passes.
Vere-Grey
requested review from
mroz22 and
STew790
and removed request for
bosomt
|
|
||
| test( | ||
| 'Overtake session by opening suite new tab', | ||
| { tag: ['@webOnly'] }, |
There was a problem hiding this comment.
Mixing electron and web would complicate our CI setup. I don't think it is worth the value. Let me know what you think.
And I assume two desktop apps running on one system is not a thing.
HajekOndrej
deleted the
feat/suite-desktop-core/convert-unaquired-device
branch
Description
Converts to PW test file unaquired-device
Renamed to multiple-sessions as I added a test that works with two tabs (something that playwright can do :) ). Feel free to challenge the renaming.
Adds bunch of verification. We found out an issue with Stew 👍
Splits test to view only enabled and disabled
Related Issue
Resolve 15606
Screenshots:
Desktop: https://app.currents.dev/instance/OVrwYg0tq2P9Ps6D
Web: https://app.currents.dev/instance/44AQxvrBBBBTzwnx