Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite): redesign FW checks UI #16599

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Lemonexe
Copy link
Contributor

@Lemonexe Lemonexe commented Jan 24, 2025

Description

  • reenable FW hash check other-error UI only for dev env
  • 👻 modal:
    • all variants have different subtitle to convey which check & what failure reason
    • other error also different title, checklist and button color = warning
  • warning banner:
    • all variants have "Contact Trezor Support" button -> goto same URL as on 👻 modal
    • other-error has color: warning

Related Issue

Resolve #16407

Screenshots:

👻 modals

hash-mismatch
ghost hash
other-error
ghost other-error
revision check
ghost rev

Banners

hash-mismatch
banner hash
other-error
banner other-error
revision check
banner rev

@Lemonexe Lemonexe force-pushed the feat/FW-hash-check-other-error-UI branch from 66e82b0 to 8363b05 Compare January 27, 2025 12:53
>
{items.map((item, index) => (
<Row key={index} gap={spacings.xl}>
{item.icon}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored because the 1️⃣ 2️⃣ icons used in the new other-error warning modal must have grey background (it does looks very awkward without them). So let's pass the whole ReactNode content instead of more props..

BTW key={index} is not ideal, but these lists are static during component lifecycle so it's ok.
Actually I think that key={item.icon} was very wrong, because it's not completely out of question that a checklist would have two points with same icons, and that would break here 😓

@Lemonexe Lemonexe marked this pull request as ready for review January 27, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Hash Check "other-error" UI
1 participant