Fix RangeError: Maximum call stack size exceeded
#16595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martykan
approved these changes
Jan 27, 2025
martykan
force-pushed
the
fix/sentry-call-stack
branch
from
dc32220 to
70b9fdd
Compare
|
I was expecting a conflict with 2b85a29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Solana websocket disconnects, the thrown
SolanaErrorhas cyclic dependency incausefield, which caused an error when sending to Sentry (it's specific to@sentry/electronpackage and its dependencydeepmerge):Dunno why Sentry serialization can't handle this e.g. by
normalizeDepthsetting, it may be a bug on their side, but the simplest solution is to remove one residualconsole.error.Related Issue
Resolve #16530