Migrate metadata tests #16583
Merged
Migrate metadata tests #16583
+510
−485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HajekOndrej
force-pushed
the
migrate-metadata-tests
branch
from
11961ea to
2aad678
Compare
Vere-Grey
reviewed
Jan 24, 2025
| await metadataProviderMock.start(MetadataProvider.DROPBOX); | ||
| }); | ||
|
|
||
| test('user cancels metadata on device, choice is respected on subsequent runs but only for the cancelled wallet', async ({ |
There was a problem hiding this comment.
I am very confused by this test, not by your conversion, that looks fine, but the original test is either too complicated for me or I lack some feature knowledge
There was a problem hiding this comment.
yeah, this one is strangely complex. Good candidate for a further test case review
Vere-Grey
approved these changes
Jan 24, 2025
packages/suite-desktop-core/e2e/tests/metadata/metadata-lifecycle.test.ts
Outdated
Show resolved
Hide resolved
packages/suite-desktop-core/e2e/tests/metadata/remembered-device.test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrated tests:
metadata-lifecycle
remembered-device
switching-providers
output-labeling
Related Issue
Resolve
Screenshots: