Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce coinmarket under feature flag #16574

Merged
merged 6 commits into from
Jan 24, 2025
Merged

introduce coinmarket under feature flag #16574

merged 6 commits into from
Jan 24, 2025

Conversation

jbazant
Copy link
Contributor

@jbazant jbazant commented Jan 23, 2025 •
edited
Loading

Description

  • Indroduce Trading module skeleton.
  • Introduce IsTradingEnabled FF.
  • Introduce methods to write component test that require redux initialized.
  • some chores

Related Issue

Resolve #16514

Screenshots:

Screenshot 2025-01-24 at 15 03 56

@jbazant jbazant self-assigned this Jan 23, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 23
  • More info

Learn more about 𝝠 Expo Github Action

@jbazant jbazant added the mobile Suite Lite issues and PRs label Jan 24, 2025
@jbazant jbazant changed the title 16514 introduce coinmarket under feature flag WIP: introduce coinmarket under feature flag Jan 24, 2025
@jbazant jbazant force-pushed the 16514-Introduce-Coinmarket-under-feature-flag branch from a12acad to c127ab4 Compare January 24, 2025 11:32
@jbazant jbazant force-pushed the 16514-Introduce-Coinmarket-under-feature-flag branch from 9c5fee9 to de6a599 Compare January 24, 2025 13:52
@jbazant jbazant force-pushed the 16514-Introduce-Coinmarket-under-feature-flag branch from de6a599 to 47489a4 Compare January 24, 2025 13:56
@jbazant jbazant changed the title WIP: introduce coinmarket under feature flag introduce coinmarket under feature flag Jan 24, 2025
@jbazant jbazant marked this pull request as ready for review January 24, 2025 18:22
@jbazant jbazant requested a review from a team as a code owner January 24, 2025 18:22
@jbazant jbazant requested review from vytick and removed request for a team January 24, 2025 18:22
vytick
vytick approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@vytick vytick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works nice. Good job! 💪

@vytick vytick merged commit 1cb0597 into develop Jan 24, 2025
81 checks passed
@vytick vytick deleted the 16514-Introduce-Coinmarket-under-feature-flag branch January 24, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vytick vytick vytick approved these changes

Assignees

@jbazant jbazant

Labels
mobile Suite Lite issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Trade section under feature flag
2 participants
@jbazant @vytick