Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(suite): eth failed tx heading #16568

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix(suite): eth failed tx heading #16568

merged 1 commit into from
Jan 24, 2025

Conversation

tomasklim
Copy link
Member

Description

  • do not use ETH tx name when tx fails

Screenshots:

Before
Screenshot 2025-01-23 at 14 01 59

Now
Screenshot 2025-01-23 at 14 00 41

@tomasklim tomasklim requested a review from izmy January 23, 2025 14:00
@bosomt
Copy link
Contributor

bosomt commented Jan 24, 2025

QA OK

Screenshot 2025-01-24 at 10 51 59 AM Screenshot 2025-01-24 at 10 51 53 AM

Info:

  • Suite version: web 25.2.0 (a425eca)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1470x956
  • Device: Trezor T3T1 2.8.7 regular (revision 8a254aa8eae82f99630df63f40e4d290066a3efc)
  • Transport: WebUsbTransport

@tomasklim tomasklim merged commit 53c913f into develop Jan 24, 2025
32 checks passed
@tomasklim tomasklim deleted the fix/eth-fail branch January 24, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izmy izmy izmy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Suite Desktop
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomasklim @bosomt @izmy