Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite-native): new welcome flow by default #16526

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

PeKne
Copy link
Contributor

@PeKne PeKne commented Jan 22, 2025

Description

  • new welcome flow used by default
  • old flow removed
  • biometrics alert removed (the choice is part of the welcome flow now)

Related Issue

Resolve #16294

Screenshots:

Screen.Recording.2025-01-22.at.12.50.31.PM.mov

@PeKne PeKne added the mobile Suite Lite issues and PRs label Jan 22, 2025
@PeKne PeKne requested a review from a team as a code owner January 22, 2025 11:52
@PeKne
Copy link
Contributor Author

PeKne commented Jan 23, 2025

Should not be merged before #16427 to prevent conflicts in E2E changes.

@yanascz
Copy link
Contributor

yanascz commented Jan 23, 2025

Can we make all the welcome screens non-scrollable? It really looks weird on iOS when they are. We had a discussion with @shenkys about this yesterday and it should be possible.

Copy link

github-actions bot commented Jan 23, 2025

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 23
  • More info

Learn more about 𝝠 Expo Github Action

Copy link
Contributor

@yanascz yanascz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looking forward to the next release!

@PeKne
Copy link
Contributor Author

PeKne commented Jan 24, 2025

/rebase

Copy link

Copy link

Rebasing failed, please rebase manually.

@PeKne PeKne force-pushed the fix/native/new-welcome-flow-by-default branch from 0fd7c37 to 22e8fcc Compare January 24, 2025 12:36
@PeKne
Copy link
Contributor Author

PeKne commented Jan 24, 2025

The android E2E tests are still failing, but it is because of DOGE backend flakiness. Not related to changes of this PR. Merging.

@PeKne PeKne merged commit bb435fa into develop Jan 24, 2025
77 of 80 checks passed
@PeKne PeKne deleted the fix/native/new-welcome-flow-by-default branch January 24, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Welcome Flow - New flow by default
2 participants