fix(suite): fix draggable window header #16437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA OK macOS
Win11
Mint
|
jvaclavik
force-pushed
the
fix-draggable-window-header
branch
from
5af384d to
cabe8e8
Compare
vojtatranta
reviewed
Jan 27, 2025
|
|
||
| if (!isVisible || !isMac || !isDesktopApp) return children; | ||
|
|
||
| return <FixForNotBeingAbleToDragWindow />; |
There was a problem hiding this comment.
NIT (meaning nitpick, if won't added, it's okay): I would add a comment here explain of why this fix is needed in these conditions, what's the root of it.
|
NIT: Overall opinion: the problem with fixes like this is that these are dependent on multiple changes in the codebase that are unrelated. I am not sure if the codebase is prepared for that. So I would at least add comments to the changes of why they are there. |
vojtatranta
approved these changes
Jan 27, 2025
jvaclavik
force-pushed
the
fix-draggable-window-header
branch
from
cabe8e8 to
d30bde9
Compare
adamhavel
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Resolve
Screenshots:
Red draggable zone is not visible anymore.