chore(suite): update network symbol naming 5 #15746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| if (networkTokenDefinitionType) { | ||
| networkTokenDefinitionType[action as TokenManagementAction] = definition.value; | ||
| networkTokenDefinitionType[action] = definition.value; |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 2 months ago
To fix the problem, we need to ensure that the type variable cannot be one of the special property names (__proto__, constructor, prototype). We can achieve this by adding a check to reject these values before using them as property names. This will prevent prototype pollution while maintaining the existing functionality.
Suggested changeset
1
suite-common/token-definitions/src/tokenDefinitionsUtils.ts
| @@ -68,2 +68,5 @@ | ||
|
|
||
| if (type === '__proto__' || type === 'constructor' || type === 'prototype') { | ||
| continue; | ||
| } | ||
| const networkTokenDefinitionType = tokenDefinitions[symbol]?.[type]; |
Copilot is powered by AI and may make mistakes. Always verify output.
tomasklim
reviewed
Dec 3, 2024
tomasklim
reviewed
Dec 3, 2024
2 tasks
adderpositive
force-pushed
the
chore/update-network-symbol-5
branch
from
274891f to
80e51ed
Compare
adderpositive
changed the title
|
/rebase |
tomasklim
approved these changes
Dec 4, 2024
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12157937322 |
trezor-ci
force-pushed
the
chore/update-network-symbol-5
branch
from
dfd1284 to
8f67c1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related
Follow up #15690
Related to #14725