-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(message-system): add ab testing message #15281
Conversation
c16f0f3
to
e412009
Compare
c5db5a1
to
cd14491
Compare
Hello @adderpositive , please let's wait for @tomasklim and let's discuss this in more broader context. Personally I do not like the idea to mix it with message system, so lets discuss. |
Yes, of course. We have been already discussing the extension of the system. I will go ahead and briefly describe it here.
I hope it is understandable a little bit. :) |
cd14491
to
4cb3aa7
Compare
Fixed |
Please make it optional. So that the app does not crash when |
packages/suite/src/components/suite/Experiment/ExperimentWrapper.tsx
Outdated
Show resolved
Hide resolved
packages/suite/src/components/suite/Experiment/ExperimentWrapper.tsx
Outdated
Show resolved
Hide resolved
Ok. In my opinion, it’s a good approach to separate messages, features, experiments, etc., but only on the application layer. On the data layer (config.vx.jsw), splitting the config into more parts would make maintenance difficult and confusing. |
4cb3aa7
to
16b8319
Compare
🚀 Expo preview is ready!
|
packages/suite/src/components/suite/Experiment/ExperimentWrapper.tsx
Outdated
Show resolved
Hide resolved
4e589d9
to
b55b152
Compare
b55b152
to
9e004f9
Compare
9e004f9
to
8df54fe
Compare
@matejkriz After our discussion, I removed strict validation. Additionally, you can see a description below if the sum does not equal 100. I hope this helps with your review. 🙃 Changes here c83ddc5 If an array of groups is empty the |
/rebase |
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12651874595 |
c83ddc5
to
f1a6ab8
Compare
Description
Example of experiments
experiments
property is placed in the top level of config.v[version].jsonconditions
are the same property as for the action - https://github.com/trezor/trezor-suite/blob/develop/docs/features/message-system.mdexperiment
has required parametersid
andgroups
id
must be unique, but can also be used for nice naming (e.g. "button-testing")groups
as an array of testing groups - minimum length of items is twopercentage
is a number between 0 and 100, a sum of all percentages has to be 100variant
can be any string - name of the groupTODO
experiments
propertyRelated Issue
Resolve #15279
Resolve #15067
Testing
This PR was tested separately. More information you can find here - #16145 and https://www.notion.so/satoshilabs/A-B-testing-170dc526060680ab9d5af4e5c9d87876