Skip to content

Fix: Prevent newRequestOptions from being generated for all services after first @DioOptions() usage #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2025
Merged

Fix: Prevent newRequestOptions from being generated for all services after first @DioOptions() usage #808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01898b7
Initial plan
Copilot Oct 20, 2025
f28d71f
Fix hasCustomOptions state leak and add test case
Copilot Oct 20, 2025
b37160b
Update test formatting for ServiceWithoutCustomOptions
Copilot Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions generator/lib/src/generator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ class RetrofitGenerator extends GeneratorForAnnotation<retrofit.RestApi> {

/// Generates the implementation class code as a string.
String _implementClass(ClassElement2 element, ConstantReader annotation) {
// Reset hasCustomOptions for each class to avoid state leaking between classes
hasCustomOptions = false;
final className = globalOptions.className ?? '_${element.name3}';
final enumString = annotation.peek('parser')?.revive().accessor;
final parser = retrofit.Parser.values.firstWhereOrNull(
Expand Down
21 changes: 21 additions & 0 deletions generator/test/src/generator_test_src.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1433,6 +1433,27 @@ abstract class CustomOptions {
Future<void> testOptions(@DioOptions() Options options);
}

// Test that a service without @DioOptions does not get newRequestOptions method
// We check by verifying that the expected code pattern is generated without newRequestOptions
@ShouldGenerate(r'''
class _ServiceWithoutCustomOptions implements ServiceWithoutCustomOptions {
_ServiceWithoutCustomOptions(this._dio, {this.baseUrl, this.errorLogger});

final Dio _dio;

String? baseUrl;

final ParseErrorLogger? errorLogger;

@override
Future<String> getData() async {
''', contains: true)
@RestApi()
abstract class ServiceWithoutCustomOptions {
@GET('/data')
Future<String> getData();
}

@ShouldGenerate('''
late User _value;
try {
Expand Down
Loading