Add MAC address and VLAN configuration to netns #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otahi
changed the title
Contributor
Author
|
@yasuhito Can you check this pull request? |
features/dsl_netns.feature
Outdated
| And "netmask" is "/25" in netns "host1" | ||
| And "default_gateway" is "192.168.8.1" in netns "host1" | ||
| And a netns named "host2" launches | ||
| And "netmask" is "/25" in netns "host2" |
Member
There was a problem hiding this comment.
Then のステップには「○○は△△となるはず」というふうに書いたほうがいいので、ここはたとえば
the netmask of "host2" should be "/25"
などとするのが良いと思います。
ちなみに、ステップの書き方のお手本としては cucumber/aruba が参考になります。
https://github.com/cucumber/aruba/blob/master/lib/aruba/cucumber/file.rb
otahi
force-pushed
the
add_netns_mac_vlan
branch
4 times, most recently
from
55e46f8 to
f896964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MAC address and VLAN configuration to netns.
ifconfigcommand withipcommand (refactoring)