Implement lakeFS document loader #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guy-har
force-pushed
the
feature/implement-document-loader
branch
from
7091a77 to
69bbfdf
Compare
nopcoder
requested changes
Mar 19, 2025
nopcoder
requested changes
Mar 21, 2025
| return partition(filename=local_path) | ||
| else: | ||
| with tempfile.TemporaryDirectory() as temp_dir: | ||
| file_path = f"{temp_dir}/{self.path.split('/')[-1]}" |
There was a problem hiding this comment.
format alternative path under temporary directory
Suggested change
| file_path = f"{temp_dir}/{self.path.split('/')[-1]}" | |
| file_path = os.path.join(temp_dir, os.path.basename(self.path)) |
tests/unit_tests/test_lakefs.py
Outdated
| import requests_mock | ||
| from requests_mock.mocker import Mocker | ||
|
|
||
| from langchain_community.document_loaders.lakefs import LakeFSLoader |
There was a problem hiding this comment.
The import from langchain_community.document_loaders.lakefs is not what I saw running in the sample code.
Based on the code it was from langchain_lakefs.document_loaders.
tests/unit_tests/test_lakefs.py
Outdated
Comment on lines
62
to
63
| # endpoint: str = "endpoint" | ||
| endpoint: str = "http://localhost:8000" |
nopcoder
approved these changes
Mar 25, 2025
|
|
||
|
|
||
| @pytest.fixture | ||
| def mock_unstructured_local() -> Any: | ||
| with patch( | ||
| "langchain_community.document_loaders.lakefs.UnstructuredLakeFSLoader" | ||
| "langchain_lakefs.document_loaders.UnstructuredLakeFSLoader" |
tests/unit_tests/test_lakefs.py
Outdated
| @@ -140,3 +96,4 @@ def test_load(self, mocker: Mocker) -> None: | |||
| loader.set_path(self.path) | |||
| documents = loader.load() | |||
| self.assertEqual(len(documents), 2) | |||
| self.assertEqual(len(documents[0].metadata),5) | |||
There was a problem hiding this comment.
Suggested change
| self.assertEqual(len(documents[0].metadata),5) | |
| self.assertEqual(len(documents[0].metadata), 5) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the lakeFS implementation from the langchain_communtiy and implements it here:
All of the implementation and tests are taken as is with the following changes