Support MSB storage #8954
Open
Support MSB storage #8954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E2E Test Results - Quickstart |
E2E Test Results - DynamoDB Local - Local Block Adapter |
guy-har
force-pushed
the
task/lakefsfs-msb-support
branch
from
95f93ab to
a36cbe9
Compare
guy-har
added
the
include-changelog
N-o-Z
approved these changes
Apr 10, 2025
| storageConfig = storageConfigList.stream() | ||
| .filter(sc -> Objects.equals(sc.getBlockstoreId(), storageID)) | ||
| .findFirst() | ||
| .orElseThrow(() -> new IOException("Failed to get lakeFS blockstore type")); |
There was a problem hiding this comment.
Suggested change
| .orElseThrow(() -> new IOException("Failed to get lakeFS blockstore type")); | |
| .orElseThrow(() -> new IOException("Failed to get lakeFS blockstore configuration")); |
arielshaqed
approved these changes
Apr 10, 2025
| @@ -287,7 +287,7 @@ To export to S3: | |||
| <dependency> | |||
| <groupId>io.lakefs</groupId> | |||
| <artifactId>sdk</artifactId> | |||
| <version>1.18.0</version> | |||
| <version>1.53.1</version> | |||
There was a problem hiding this comment.
Non blocking. As always, I prefer big version bumps to occur in separate PRs. Otherwise if things break, it is harder to tell if the breakage was due to the version bump or due to the change in functionality.
| .execute(); | ||
| String storageID = repository.getStorageId(); | ||
| Config cfg = lfsClient.getConfigApi().getConfig().execute(); | ||
| StorageConfig storageConfig = new StorageConfig(); |
There was a problem hiding this comment.
I don't understand - why create a blank StorageConfig? If there is a bug and nothing is found, do you really want a blank StorageConfig???
Suggested change
| StorageConfig storageConfig = new StorageConfig(); | |
| StorageConfig storageConfig; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes treeverse/lakeFS-enterprise#48
Change Description
This change provides the lakeFSFS to support storage config list case
This change:
How was this tested
This was tested by running the sonnets test locally with the following information: