Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StorageID from committed.iterator #8824

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

itaigilo
Copy link
Contributor

Cleanup:
The storageID of committed.manager isn't used,
Removing it.

@itaigilo itaigilo added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached msb labels Mar 20, 2025
Copy link
Contributor

@guy-har guy-har left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itaigilo itaigilo enabled auto-merge (squash) March 20, 2025 10:02
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as it seems that it should never had to have the storage id in the first place.

Copy link

github-actions bot commented Mar 20, 2025

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed, 1 failed

Test failures:
  Object Viewer - Parquet File › view parquet object w/ logout and login: common/viewParquetObject.spec.ts

viewParquetObject.spec.ts:28:9 view parquet object w/ logout and login

[common] › common/viewParquetObject.spec.ts:28:9 › Object Viewer - Parquet File › view parquet object w/ logout and login

Error: page.goto: Navigation to "http://localhost:8000/repositories" is interrupted by another navigation to "http://localhost:8000/"
Call log:
  - navigating to "http://localhost:8000/repositories", waiting until "load"


   at poms/repositoriesPage.ts:25

  23 |
  24 |     async goto(): Promise<void> {
> 25 |         await this.page.goto("/repositories");
     |                         ^
  26 |     }
  27 |
  28 |     async goToRepository(repoName: string): Promise<void> {

    at RepositoriesPage.goto (/home/runner/work/lakeFS/lakeFS/webui/test/e2e/poms/repositoriesPage.ts:25:25)
    at /home/runner/work/lakeFS/lakeFS/webui/test/e2e/common/viewParquetObject.spec.ts:41:32

attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
test-results/common-viewParquetObject-Object-Viewer---Parquet-File-view-parquet-object-w-logout-and-login-common/trace.zip
Usage:

    npx playwright show-trace test-results/common-viewParquetObject-Object-Viewer---Parquet-File-view-parquet-object-w-logout-and-login-common/trace.zip

────────────────────────────────────────────────────────────────────────────────────────────────

This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.

Copy link

E2E Test Results - Quickstart

11 passed

@itaigilo itaigilo merged commit 0776b45 into master Mar 20, 2025
46 of 47 checks passed
@itaigilo itaigilo deleted the task/remove-storage-id-from-committed-iterator branch March 20, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached msb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants