Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage_id tag to StorageAdapter metrics #8786

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

itaigilo
Copy link
Contributor

Closes #8672.

(Replacing PR #8680.)

Change Description

Adding storage_id as a tag when reporting prometheus metrics.

Also, renaming the stats files into metrics.

Testing

Tested manually on a local env.

@itaigilo itaigilo added exclude-changelog PR description should not be included in next release changelog msb labels Mar 10, 2025
@itaigilo itaigilo requested review from arielshaqed, guy-har and a team March 10, 2025 15:48
Copy link
Contributor

@guy-har guy-har left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks!!!

Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

14 passed

Copy link

E2E Test Results - Quickstart

11 passed

@itaigilo itaigilo merged commit de97a9b into master Mar 12, 2025
45 checks passed
@itaigilo itaigilo deleted the feature/add-storage-id-tag-to-metrics branch March 12, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-changelog PR description should not be included in next release changelog msb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow label in Metrics Adapter
2 participants