HL Python SDK: Support storage id #8742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-o-Z
added
area/sdk/python
exclude-changelog
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
guy-har
approved these changes
Mar 3, 2025
| @@ -684,6 +685,16 @@ def stat(self) -> ObjectInfo: | |||
| self._stats = ObjectInfo(**stat.dict()) | |||
| return self._stats | |||
|
|
|||
| def storage_id(self) -> str: | |||
| """ | |||
| Return the Stat object representing this object | |||
itaigilo
requested changes
Mar 3, 2025
| @@ -1,5 +1,5 @@ | |||
| aenum~=3.1.15 | |||
| lakefs-sdk>=1.47, < 2 | |||
| lakefs-sdk>=1.50, < 2 | |||
There was a problem hiding this comment.
Does this version include our latest changes regarding config defaults?
There was a problem hiding this comment.
What are the config defaults? How is lakeFS python SDK relevant?
As long as we are not changing the response structure this version is enough to support what we need
|
|
||
| def __init__(self, client: Optional[Client] = None): | ||
| try: | ||
| self._conf = client.sdk_client.config_api.get_config() | ||
| self._storage_conf = ServerStorageConfiguration(**self._conf.storage_config.dict()) | ||
| if self._conf.storage_config_list is not None: |
There was a problem hiding this comment.
How will either of the changes affect the behavior of the underlying code?
In either way to will behave in the same manner it works today
There was a problem hiding this comment.
Well these should be fine now.
itaigilo
approved these changes
Mar 3, 2025
|
|
||
| def __init__(self, client: Optional[Client] = None): | ||
| try: | ||
| self._conf = client.sdk_client.config_api.get_config() | ||
| self._storage_conf = ServerStorageConfiguration(**self._conf.storage_config.dict()) | ||
| if self._conf.storage_config_list is not None: |
There was a problem hiding this comment.
Well these should be fine now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8740
Verified with existing unit tests and manual testing