-
Notifications
You must be signed in to change notification settings - Fork 371
test: Fixes intermittent test failure related to CosmosDB #8660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nopcoder
wants to merge
14
commits into
master
Choose a base branch
from
chore/test-cosmosdb
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd4cea6
to
9bf455d
Compare
- No magic numbers - Adjusted the client timeout to 30 seconds for the CosmosDB client in the main_test.go file. - Updated the client configuration in the cosmosdb.go file to include a timeout of 5 seconds.
…ta persistence options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/KV
Improvements to the KV store implementation
area/testing
Improvements or additions to tests
exclude-changelog
PR description should not be included in next release changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8659
TestCosmosDB
function to includet.Helper()
for better test helper function behavior.