[CENNSO-1767] feat: pfcp requests metrics #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demo-exe
changed the title
demo-exe
changed the title
mogaika
requested changes
Feb 20, 2024
upf/upf.h
Outdated
| // total of PFCP messages received - corrupted | ||
| UPF_PFCP_RECEIVED_CORRUPTED = 11, | ||
| // PFCP request received | ||
| // parts of program depend on order - OK then ERROR for the same type |
There was a problem hiding this comment.
maybe
Suggested change
| // parts of program depend on order - OK then ERROR for the same type | |
| // message _ERROR counter always should be after _OK, since arithmetic used to access it |
upf/upf.h
Outdated
| UPF_N_COUNTERS = 11, | ||
| // total of PFCP messages received - corrupted | ||
| UPF_PFCP_RECEIVED_CORRUPTED = 11, | ||
| // PFCP request received |
There was a problem hiding this comment.
not only requests, maybe messages?
upf/upf.h
Outdated
| UPF_PFCP_ASSOCIATION_RELEASE_REQUEST_ERROR = 29, | ||
| UPF_PFCP_ASSOCIATION_RELEASE_RESPONSE_OK = 30, | ||
| UPF_PFCP_ASSOCIATION_RELEASE_RESPONSE_ERROR = 31, | ||
| // PFCP but sent the other way |
There was a problem hiding this comment.
Suggested change
| // PFCP but sent the other way |
upf/upf.h
Outdated
| @@ -1173,4 +1270,20 @@ u8 *upf_name_to_labels (u8 *name); | |||
|
|
|||
| __clib_export void upf_nat_get_src_port (vlib_buffer_t *b, u16 port); | |||
|
|
|||
| always_inline void | |||
| upf_increment_counter (upf_counters_type_t counter, u32 index, u64 count) | |||
There was a problem hiding this comment.
Suggested change
| upf_increment_counter (upf_counters_type_t counter, u32 index, u64 count) | |
| upf_increment_counter (upf_counters_type_t counter, u32 index, u64 increment) |
upf/upf_pfcp_api.c
Outdated
| return -1; | ||
| } | ||
|
|
||
| if (r != 0) /* if cause != 0 */ | ||
| { | ||
| upf_debug ("PFCP: error response %d", r); | ||
| upf_increment_counter (UPF_PFCP_RECEIVED_CORRUPTED, 0, 1); |
There was a problem hiding this comment.
feels like we could use UPF_PFCP_***_ERROR here as well, since type is known and error response is sent
mogaika
reviewed
Feb 20, 2024
mogaika
reviewed
Feb 20, 2024
mogaika
requested changes
Feb 20, 2024
upf/upf.h
Outdated
Comment on lines
526
to
529
| UPF_PFCP_RX_HB_REQUEST_OK = 12, | ||
| UPF_PFCP_RX_HB_REQUEST_ERROR = 13, | ||
| UPF_PFCP_RX_HB_RESPONSE_OK = 14, | ||
| UPF_PFCP_RX_HB_RESPONSE_ERROR = 15, |
There was a problem hiding this comment.
what I meant with RX is that each counter may have this prefix to clarify that counter is for received message. So either all, either none
There was a problem hiding this comment.
huh thought that HB could be sent 2 ways, my bad
Id go without those prefixes
mogaika
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.