Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT - B - 21423 prime int sit service item #14678

Open
wants to merge 34 commits into
base: integrationTesting
Choose a base branch
from

Conversation

MInthavongsay
Copy link
Contributor

@MInthavongsay MInthavongsay commented Jan 28, 2025

B-21423

Summary

This PR adds functionality to create international SIT service items to Prime (v1). In addition, it also contains the ability to update international SITs and the display of detailed information of SITs on the TOO details view. There are no BLs to address updates and display.

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Login as customer. Create and submit HHG with Alaska origin and/or destination addresses.
  2. Login as new service counselor. Click Move Details.
  3. Login as TOO. Select HHG and select approve.
  4. Login as Prime Sim. Find move code and click .
  5. For Service Item Type, verify there are options for International Origin SIT and International Destination SIT.
  6. Select International Origin SIT and fill out form. Click create service item. Verify 4 service SIT items are created after page redirect/refresh.
    Screenshot 2025-01-28 at 4 59 49 PM
  7. Select International Destination SIT and fill out form. Click create service item. Verify 4 service SIT items are created after page redirect/refresh.
    Screenshot 2025-01-28 at 5 01 37 PM
  8. Login TOO. Verify 2 sets of SIT service items are present to approve/reject for international origin and destination SITs. Verify details of individual are displayed correctly. Use domestic origin/destination SITs as reference. Note: There is an issue with "Delivery miles into SIT" for international SITs. This needs to be addressed in another BL.
    Screenshot 2025-01-28 at 5 09 17 PM
  9. Play around with the SITs by approving/rejecting/editing(if available). Confirm behavior should be identical to domestic SITs.
  10. Log back into Prime Sim and test update for each SITs. Behavior should be the same as domestic.
  11. Log back into TOO and verify updated SITs have been updated.
  12. Verify Reject. Behavior should be the same as domestic.
  13. Try to break it!
  14. Go to swagger: http://primelocal:3000/swagger-ui/prime.html#/mtoServiceItem/createMTOServiceItem . Use Prime Sim UI to get sample JSON payload via web developer tool.
    Screenshot 2025-01-28 at 11 54 19 AM
  15. Go to swagger: http://primelocal:3000/swagger-ui/prime.html#/mtoServiceItem/updateMTOServiceItem . Use Prime Sim UI to get sample JSON payload via web developer tool. Submit and verify via UI update data is present.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@MInthavongsay MInthavongsay self-assigned this Jan 28, 2025
@robot-mymove
Copy link

robot-mymove commented Jan 28, 2025

Warnings
⚠️ This PR does not include changes to storybook, even though it affects component code.

Generated by 🚫 dangerJS against 86fe5c4

@MInthavongsay MInthavongsay added INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H labels Jan 28, 2025
@MInthavongsay MInthavongsay changed the title Int b 21423 prime int sit service item INT - B - 21423 prime int sit service item Jan 28, 2025
@MInthavongsay MInthavongsay marked this pull request as ready for review January 28, 2025 22:37
@MInthavongsay MInthavongsay requested review from a team as code owners January 28, 2025 22:37
Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some little stuff during static review, use variables where ya can for the UI

pkg/handlers/primeapi/payloads/payload_to_model.go Outdated Show resolved Hide resolved
pkg/handlers/primeapi/payloads/payload_to_model.go Outdated Show resolved Hide resolved
pkg/handlers/primeapi/payloads/payload_to_model.go Outdated Show resolved Hide resolved
pkg/handlers/primeapiv2/payloads/payload_to_model.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ajlusk ajlusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These mostly seem like copy & paste errors.

The core functionality seems to work as described and I haven't been able to break it yet other than these little things.

@MInthavongsay MInthavongsay requested a review from ajlusk January 31, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

5 participants