B 21544 prime successful update message main #14632
Draft
+43
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
taeJungCaci
previously requested changes
Jan 22, 2025
Comment on lines
239
to
266
| it('routes to the review page when the user clicks save', async () => { | ||
| usePrimeSimulatorGetMove.mockReturnValue(moveReturnValue); | ||
| updateShipmentDestinationAddress.mockReturnValue({ | ||
| id: 'c56a4180-65aa-42ec-a945-5fd21dec0538', | ||
| streetAddress1: '444 Main Ave', | ||
| streetAddress2: 'Apartment 9000', | ||
| streetAddress3: '', | ||
| city: 'Anytown', | ||
| state: 'AL', | ||
| postalCode: '90210', | ||
| country: 'USA', | ||
| eTag: '1234567890', | ||
| setFlashMessage: jest.fn(), | ||
| }); | ||
| renderComponent(); | ||
|
|
||
| const addressChange = screen.getByLabelText('Address 1'); | ||
| const contractorRemarks = screen.getByLabelText('Contractor Remarks'); | ||
| await act(() => userEvent.type(addressChange, 'Address Tester')); | ||
| await act(() => userEvent.type(contractorRemarks, 'testing contractor remarks')); | ||
|
|
||
| const saveButton = await screen.findByRole('button', { name: 'Save' }); | ||
| await act(() => userEvent.click(saveButton)); | ||
|
|
||
| await waitFor(() => { | ||
| expect(mockNavigate).toHaveBeenCalledWith(movePath); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I think test above your added test is already checking this - line where it starts with describe('successful submission of form', () => {.
Your should just be able to add this test:
expect(mockSetFlashMessage).toHaveBeenCalledTimes(1);
with
await waitFor(() => {
expect(mockNavigate).toHaveBeenCalledWith('/simulator/moves/LN4T89/details');
});
There was a problem hiding this comment.
You can also use .toHaveBeenCalledWith() if you want to check details
Comment on lines
102
to
112
| // const mockedComponent = ( | ||
| // <MockProviders path={primeSimulatorRoutes.SHIPMENT_UPDATE_DESTINATION_ADDRESS_PATH} params={routingParams}> | ||
| // <PrimeUIShipmentUpdateDestinationAddress setFlashMessage={jest.fn()} /> | ||
| // </MockProviders> | ||
| // ); | ||
|
|
||
| const movePath = generatePath(primeSimulatorRoutes.VIEW_MOVE_PATH, { | ||
| moveCodeOrID: 'LN4T89', | ||
| setFlashMessage: jest.fn(), | ||
| }); | ||
|
|
There was a problem hiding this comment.
don't need these I don't think
|
|
||
| import { usePrimeSimulatorGetMove } from '../../../hooks/queries'; | ||
| import { updateShipmentDestinationAddress } from '../../../services/primeApi'; | ||
|
|
||
| import PrimeUIShipmentUpdateDestinationAddress from './PrimeUIShipmentUpdateDestinationAddress'; | ||
|
|
||
| // import { setFlashMessage } from 'store/flash/actions'; | ||
| import { ReactQueryWrapper, MockProviders } from 'testUtils'; | ||
| import { primeSimulatorRoutes } from 'constants/routes'; | ||
|
|
There was a problem hiding this comment.
Add this mock for the flashmessage:
const mockSetFlashMessage = jest.fn();
jest.mock('react-redux', () => ({
...jest.requireActual('react-redux'),
connect: jest.fn(() => (component) => (props) => component({ ...props, setFlashMessage: mockSetFlashMessage })),
}));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
Summary
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots