B 21339 int - Bulk assignment modal: UI Layout and populate data (SC/TOO) #14585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o B-21339-main
JonSpight
added
G-Unit
danieljordan-caci
previously approved these changes
Jan 30, 2025
loganwc
previously approved these changes
Jan 30, 2025
|
Need to address your storybook - looks wonky donky |
JonSpight
dismissed stale reviews from danieljordan-caci and loganwc
via
3dd030f
| @@ -15,4 +15,12 @@ const ConnectedTemplate = (args) => <BulkAssignmentModal {...args} />; | |||
| export const ConnectedModal = ConnectedTemplate.bind({}); | |||
| ConnectedModal.args = { | |||
| isOpen: true, | |||
| bulkAssignmentData: { | |||
There was a problem hiding this comment.
Can't see this data in happo so just take it out imo
danieljordan-caci
requested changes
Jan 31, 2025
There was a problem hiding this comment.
Bulk assignment button is still slightly different in size than the export button - need to make those the same height at least
Also, what's the desired outcome when a user has a really long name? Right now the modal has a side scrolling box, which I don't really like. Have any thoughts on that?
Screen.Recording.2025-01-31.at.9.19.31.AM.mov
You can prevent that side scrolling behavior by adding overflow-x: hidden to your scss but you'd also need to cover down and ensure that the modal doesn't get wider than the view screen. Can add a max-width for that.
.BulkModal {
min-width: 650px !important;
max-width: 90vw;
overflow-y: auto;
max-height: 90vh;
overflow-x: hidden;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
Summary
This will be from the SC (Counseling) and TOO user. This will cover the Bulk Assignment button from both the Counseling queue and Task Order queue.
Important
This PR contains code from SC: Create endpoint 21337 and should be merged after
This PR contains code from TOO: Create endpoint 21445 and should be merged after
This PR contains code from Add bulk assignment button and modal 21336 and should be merged after
How to test
Screenshots