B-21378: Introduce iUB RDD Transit Calculation

[TevinAdams]

Agility ticket

Summary

In this PR the goal was to make sure the Required Delivery Date on a UB shipment is populated. To populate the field there are some requirements.

1. The shipment must have a scheduled pickup date
2. The shipment must be a UB shipment

Required delivery date for a UB shipment is made using the following formula:
rdd = (scheduledPickupDate + 1 day) + re_intl_transit_times.ub_transit_time
Then that rdd value is applied to the UB shipment

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

*Note: There may not be a re_intl_transit_times record with a origin_rate_area_id and a destination_rate_area_id that both exists in re_oconus_rate_areas.
In that case you will have to edit an intl_transit_time_record in the DB to have an origin and destination rate area id that does exist in the re_oconus_rate_areas table.

select *
from re_intl_transit_times
where origin_rate_area_id in (select rate_area_id from re_oconus_rate_areas)
and destination_rate_area_id in (select rate_area_id from re_oconus_rate_areas)

1. Create a UB shipment as a MyMove user

• Use addresses that have a us_post_region_cities_id that exist in a record in re_oconus_rate_areas table
• Current address I used an address in zipcode 29229
• Current duty location: Fort Jackson
• Duty Location: Use a duty location that has an address that has a us_post_region_cities_id in re_oconus_rate_areas. In my case I used Eielson, AFB

2. As SC counsel move
3. As TOO approve move
4. As Prime update the shipment with a scheduled pickup date
5. Check the shipment in the DB and make sure the Required delivery date is populated

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[danieljordan-caci]

Conflicts

[cameroncaci]

Does not appear to function for Prime V3 path updateMTOShipment API call via postman. RDD is only calculated on UpdateMTOShipmentStatus service, which is not called by UpdateMTOShipment within mto_shipment_updater.go

An error should also likely return if RDD can't be calculated for the RDD

Endpoint http://primelocal:3000/prime/v3/mto-shipments/:mtoShipmentID
Shipment ID being a UB shipment

{
  "scheduledDeliveryDate": "2025-01-20"
}

[TevinAdams]

Missing tests

@cameroncaci additional tests added. Went through with the debugger and those lines are hit by tests.

[danieljordan-caci]

You have a failing server test

[TevinAdams]

You have a failing server test

@danieljordan-caci Fixed

[danieljordan-caci]

Looks good! Able to update the scheduled pickup date and the RDD sets/adjusts for UB shipments.

[danieljordan-caci]

oh wait, retract that approval - I see you have failing tests still

Resolved.