Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int b 21507 pod poe too validation #14557

Merged
merged 12 commits into from
Jan 13, 2025

Conversation

msaki-caci
Copy link
Contributor

@msaki-caci msaki-caci commented Jan 9, 2025

B-21507

Summary

Bulk of the work was completed and merged here.

This PR is just to make it so the Port Location has its own box SEPARATE from the Authorized Addresses box.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

NOTE: We are following the same steps for 1-5 from B-21505 to setup the location for the POE/POD.

  1. Create an INTL UB shipment as a customer (CONUS -> AK or AK -> CONUS)

  2. Manually create the mto_service_items table for the shipment: INSERT INTO mto_service_items ( id, mto_shipment_id, move_id, re_service_id, status, created_at, updated_at, approved_at ) VALUES ( uuid_generate_v4(), '8eeba537-bb40-4f58-a534-74ea9ff64590', '813b7a43-2e3f-42f3-8c4e-eca95390d5ca', '388115e8-abe9-441d-96cf-a39f24baa0a3', 'APPROVED'::service_item_status, NOW(), NOW(), NOW() );

  3. In the prime v3 api, call getMoveTaskOrder using the move_id for the service item you created in step 2. You will need the etag for the newly created service item for the next step.

  4. In the prime v1 api, call updateMTOServiceItem using a payload like this (adjust for you specific service item ID): { "id": "40b7e71a-6b03-4413-8601-dea694253ee3", "modelType": "UpdateMTOServiceItemInternationalPortFSC", "portCode": "PDX", "reServiceCode": "PODFSC" }

  5. Verify that you receive a 200 response like this: { "reServiceCode": "PODFSC", "eTag": "MjAyNC0xMi0wMlQxNjo0MjoxNi42NjUwNDla", "id": "40b7e71a-6b03-4413-8601-dea694253ee3", "modelType": "MTOServiceItemBasic", "moveTaskOrderID": "813b7a43-2e3f-42f3-8c4e-eca95390d5ca", "mtoShipmentID": "8eeba537-bb40-4f58-a534-74ea9ff64590", "reServiceName": "International POD Fuel Surcharge", "status": "APPROVED" }

  6. Login as a TOO user or any office user that has permissions to access the MTO page. Search up the move id that we used to setup the POD/POE. When you travel to the MTO Page, you should now see the Port of Embark or Debark populated with the Port Code, Port Name, City, State, and Zip associated with it.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Screenshots

image

Create a separate table for viewing the Port address
Make a new PortTable component
Remove references to POD/POE Location from ShipmentAddresses.jsx and test file
Create a new test file for Port Table
Refactor display for Port Table on ShipmentDetailsMain
Add test when poeLocation is provided
Add test when podLocation is provided
Add test for when neither location is provided
@msaki-caci msaki-caci marked this pull request as ready for review January 10, 2025 16:18
@msaki-caci msaki-caci requested a review from a team as a code owner January 10, 2025 16:18
Add test for valid POE
Add test for valid POD
Add test for NULL values for POE/POD
@msaki-caci msaki-caci marked this pull request as ready for review January 10, 2025 17:22
@msaki-caci msaki-caci marked this pull request as draft January 10, 2025 18:12
Create storybook for the PortTable component with POD and POE views
Rename variable for setting POE location and POD location
@msaki-caci msaki-caci marked this pull request as ready for review January 10, 2025 19:28
@antgmann
Copy link
Contributor

Accepted Happo diffs, still reviewing

Copy link
Contributor

@antgmann antgmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good as far as I can tell frontend wise. Storybook component works nicely, tests look good. ANDI is passing:
image

Only thing to keep in the back of our minds I think isn't really for what this work is focused on, but it seems like UB shipments need to be added to a couple of enums somewhere to prevent additional console errors such as these two:
image

Just wanted to document the above in case you guys are doing a lot with UB and see somewhere that work might fit nicely. Otherwise it could be added to a general frontend fixes feature we have open on agility.

Thanks for the good work!

Copy link
Contributor

@deandreJones deandreJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding storybook for the new component
and tests!!

looks good

@msaki-caci
Copy link
Contributor Author

Everything looks good as far as I can tell frontend wise. Storybook component works nicely, tests look good. ANDI is passing: image

Only thing to keep in the back of our minds I think isn't really for what this work is focused on, but it seems like UB shipments need to be added to a couple of enums somewhere to prevent additional console errors such as these two: image

Just wanted to document the above in case you guys are doing a lot with UB and see somewhere that work might fit nicely. Otherwise it could be added to a general frontend fixes feature we have open on agility.

Thanks for the good work!

Yeah I have been noticing some funkiness with UB shipments on this BL and another one I am working on. I imagine that what you are saying is probably related. I will try to keep a look out for these things and fix them the further down the "UB rabbit hole" I go

@antgmann
Copy link
Contributor

Yeah I have been noticing some funkiness with UB shipments on this BL and another one I am working on. I imagine that what you are saying is probably related. I will try to keep a look out for these things and fix them the further down the "UB rabbit hole" I go

Sounds great, thank you!

Copy link
Contributor

@brianmanley-caci brianmanley-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me 👍

image

@msaki-caci msaki-caci merged commit bd28e7f into integrationTesting Jan 13, 2025
35 checks passed
@msaki-caci msaki-caci deleted the INT-B-21507_POD-POE_TOO_Validation branch January 13, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants