-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Int b 21507 pod poe too validation #14557
Int b 21507 pod poe too validation #14557
Conversation
Create a separate table for viewing the Port address Make a new PortTable component
Remove references to POD/POE Location from ShipmentAddresses.jsx and test file Create a new test file for Port Table Refactor display for Port Table on ShipmentDetailsMain
…OD-POE_TOO_Validation
Add test when poeLocation is provided Add test when podLocation is provided Add test for when neither location is provided
…OD-POE_TOO_Validation
Add test for valid POE Add test for valid POD Add test for NULL values for POE/POD
…OD-POE_TOO_Validation
Create storybook for the PortTable component with POD and POE views Rename variable for setting POE location and POD location
…OD-POE_TOO_Validation
Accepted Happo diffs, still reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good as far as I can tell frontend wise. Storybook component works nicely, tests look good. ANDI is passing:
Only thing to keep in the back of our minds I think isn't really for what this work is focused on, but it seems like UB shipments need to be added to a couple of enums somewhere to prevent additional console errors such as these two:
Just wanted to document the above in case you guys are doing a lot with UB and see somewhere that work might fit nicely. Otherwise it could be added to a general frontend fixes feature we have open on agility.
Thanks for the good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding storybook for the new component
and tests!!
looks good
Sounds great, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
B-21507
Summary
Bulk of the work was completed and merged here.
This PR is just to make it so the Port Location has its own box SEPARATE from the Authorized Addresses box.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Create an INTL UB shipment as a customer (CONUS -> AK or AK -> CONUS)
Manually create the mto_service_items table for the shipment:
INSERT INTO mto_service_items ( id, mto_shipment_id, move_id, re_service_id, status, created_at, updated_at, approved_at ) VALUES ( uuid_generate_v4(), '8eeba537-bb40-4f58-a534-74ea9ff64590', '813b7a43-2e3f-42f3-8c4e-eca95390d5ca', '388115e8-abe9-441d-96cf-a39f24baa0a3', 'APPROVED'::service_item_status, NOW(), NOW(), NOW() );
In the prime v3 api, call getMoveTaskOrder using the move_id for the service item you created in step 2. You will need the etag for the newly created service item for the next step.
In the prime v1 api, call updateMTOServiceItem using a payload like this (adjust for you specific service item ID):
{ "id": "40b7e71a-6b03-4413-8601-dea694253ee3", "modelType": "UpdateMTOServiceItemInternationalPortFSC", "portCode": "PDX", "reServiceCode": "PODFSC" }
Verify that you receive a 200 response like this:
{ "reServiceCode": "PODFSC", "eTag": "MjAyNC0xMi0wMlQxNjo0MjoxNi42NjUwNDla", "id": "40b7e71a-6b03-4413-8601-dea694253ee3", "modelType": "MTOServiceItemBasic", "moveTaskOrderID": "813b7a43-2e3f-42f3-8c4e-eca95390d5ca", "mtoShipmentID": "8eeba537-bb40-4f58-a534-74ea9ff64590", "reServiceName": "International POD Fuel Surcharge", "status": "APPROVED" }
Login as a TOO user or any office user that has permissions to access the MTO page. Search up the move id that we used to setup the POD/POE. When you travel to the MTO Page, you should now see the Port of Embark or Debark populated with the Port Code, Port Name, City, State, and Zip associated with it.
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Screenshots